Skip to content

WIP config: allow user to know type of config options #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 514 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
514 commits
Select commit Hold shift + click to select a range
3037d3d
t5520: use test_line_count where possible
Denton-L Nov 12, 2019
979f889
t5520: replace test -{n,z} with test-lib functions
Denton-L Nov 12, 2019
dd0f1e7
t5520: use test_cmp_rev where possible
Denton-L Nov 12, 2019
5540ed2
t5520: test single-line files by git with test_cmp
Denton-L Nov 12, 2019
e959a18
t5520: don't put git in upstream of pipe
Denton-L Nov 12, 2019
a1a64fd
t5520: replace $(cat ...) comparison with test_cmp
Denton-L Nov 12, 2019
c245e58
t5520: remove redundant lines in test cases
Denton-L Nov 12, 2019
2a02262
t5520: replace `! git` with `test_must_fail git`
Denton-L Nov 12, 2019
df6d3d6
lib-bash.sh: move `then` onto its own line
Denton-L Nov 21, 2019
679f2f9
unpack-trees: skip stat on fsmonitor-valid files
utsav-dbx Nov 20, 2019
392b862
gpg-interface: refactor the free-and-xmemdupz pattern
illikainen Nov 21, 2019
67a6ea6
gpg-interface: limit search for primary key fingerprint
illikainen Nov 22, 2019
ea8b7be
git svn: stop using `rebase --preserve-merges`
dscho Nov 22, 2019
2d05ef2
sequencer: fix empty commit check when amending
phillipwood Nov 22, 2019
43a2afe
tests: add 'test_bool_env' to catch non-bool GIT_TEST_* values
szeder Nov 22, 2019
a85efb5
t5608-clone-2gb.sh: turn GIT_TEST_CLONE_2GB into a bool
szeder Nov 22, 2019
eea4a7f
mingw: demonstrate that all file handles are inherited by child proce…
dscho Nov 22, 2019
c5a03b1
mingw: work around incorrect standard handles
dscho Nov 22, 2019
9a780a3
mingw: spawned processes need to inherit only standard handles
dscho Nov 22, 2019
ac33519
mingw: restrict file handle inheritance only on Windows 7 and later
dscho Nov 22, 2019
befd4f6
sequencer: don't re-read todo for revert and cherry-pick
szeder Nov 23, 2019
8d483c8
doc: document 'git submodule status --cached'
Manishearth Nov 23, 2019
f0e58b3
doc: mention that 'git submodule update' fetches missing commits
phil-blain Nov 24, 2019
0a8e303
reset: parse rev as tree-ish in patch mode
mystor Nov 24, 2019
ebc3278
git-compat-util.h: drop the `PRIuMAX` and other fallback definitions
harry-hov Nov 24, 2019
ffa1f28
revision: clear the topo-walk flags in reset_revision_walk
glandium Nov 22, 2019
0aa0c2b
revision: free topo_walk_info before creating a new one in init_topo_…
glandium Nov 22, 2019
8638114
sequencer: update `total_nr' when adding an item to a todo list
agrn Nov 24, 2019
3406554
sequencer: update `done_nr' when skipping commands in a todo list
agrn Nov 24, 2019
3f34f2d
sequencer: move the code writing total_nr on the disk to a new function
agrn Nov 24, 2019
a2dd67f
rebase: fill `squash_onto' in get_replay_opts()
agrn Nov 24, 2019
393adf7
sequencer: directly call pick_commits() from complete_action()
agrn Nov 24, 2019
1f3aea2
submodule: fix 'submodule status' when called from a subdirectory
Manishearth Nov 25, 2019
d82dfa7
rebase -i: finishing touches to --reset-author-date
gitster Nov 21, 2019
fc42f20
test-lib-functions: suppress a 'git rev-parse' error in 'test_commit_…
szeder Nov 25, 2019
b8dcc45
perf-lib: use a single filename for all measurement types
peff Nov 25, 2019
528d9e6
t/perf: don't depend on Git.pm
peff Nov 25, 2019
44a4693
progress: create GIT_PROGRESS_DELAY
derrickstolee Nov 25, 2019
ecc0869
commit-graph: use start_delayed_progress()
derrickstolee Nov 25, 2019
a6293f5
fetch: use skip_prefix() instead of starts_with()
rscharfe Nov 26, 2019
7e412e8
fmt-merge-msg: use skip_prefix() instead of starts_with()
rscharfe Nov 26, 2019
ec6ee0c
shell: use skip_prefix() instead of starts_with()
rscharfe Nov 26, 2019
1768aaf
push: use skip_prefix() instead of starts_with()
rscharfe Nov 26, 2019
2059e79
name-rev: use skip_prefix() instead of starts_with()
rscharfe Nov 26, 2019
54a7a64
run-command: use prepare_git_cmd() in prepare_cmd()
rscharfe Nov 26, 2019
a5d04a3
t1512: use test_line_count
rscharfe Nov 26, 2019
6e4826e
t1410: use test_line_count
rscharfe Nov 26, 2019
c93a5aa
t1400: use test_must_be_empty
rscharfe Nov 26, 2019
213dabf
test: use test_must_be_empty F instead of test -z $(cat F)
rscharfe Nov 26, 2019
c74b3cb
t7812: add missing redirects
andreas-schwab Nov 26, 2019
ed25471
test: use test_must_be_empty F instead of test_cmp empty F
rscharfe Nov 27, 2019
176441b
ci: build Git with GCC 9 in the 'osx-gcc' build job
szeder Nov 27, 2019
77a946b
apply-one-time-sed.sh: modernize style
Denton-L Nov 27, 2019
17aa9d9
t0014: remove git command upstream of pipe
Denton-L Nov 27, 2019
9b5a9fa
t0090: stop losing return codes of git commands
Denton-L Nov 27, 2019
29a40b5
t3301: stop losing return codes of git commands
Denton-L Nov 27, 2019
0d913df
t3600: use test_line_count() where possible
Denton-L Nov 27, 2019
3b73738
t3600: stop losing return codes of git commands
Denton-L Nov 27, 2019
50cd31c
t3600: comment on inducing SIGPIPE in `git rm`
Denton-L Nov 27, 2019
946d235
t4015: stop losing return codes of git commands
Denton-L Nov 27, 2019
afd43c9
t4015: use test_write_lines()
Denton-L Nov 27, 2019
b66e0a1
t4138: stop losing return codes of git commands
Denton-L Nov 27, 2019
6c37f3e
t5317: stop losing return codes of git commands
Denton-L Nov 27, 2019
a29b242
t5317: use ! grep to check for no matching lines
Denton-L Nov 27, 2019
eacaa1c
t5703: simplify one-time-sed generation logic
Denton-L Nov 27, 2019
763b47b
t5703: stop losing return codes of git commands
Denton-L Nov 27, 2019
38c1aa0
t7501: remove spaces after redirect operators
Denton-L Nov 27, 2019
756ee7f
t7501: stop losing return codes of git commands
Denton-L Nov 27, 2019
0927908
t7700: drop redirections to /dev/null
Denton-L Nov 27, 2019
7a1c8c2
t7700: remove spaces after redirect operators
Denton-L Nov 27, 2019
d2eee32
t7700: move keywords onto their own line
Denton-L Nov 27, 2019
17a4ae9
t7700: s/test -f/test_path_is_file/
Denton-L Nov 27, 2019
5cf7a17
send-pack: use OBJECT_INFO_QUICK to check negative objects
peff Nov 27, 2019
46c6749
doc: recommend lore.kernel.org over public-inbox.org
peff Nov 27, 2019
3eae30e
doc: replace public-inbox links with lore.kernel.org
peff Nov 27, 2019
f6b9413
sequencer: fix a memory leak in sequencer_continue()
agrn Nov 28, 2019
65efb42
t9300: don't create unused file
rscharfe Nov 27, 2019
271c351
t7811: don't create unused file
rscharfe Nov 27, 2019
ccd4694
date.c: switch to reentrant {gm,local}time_r
sgn Nov 28, 2019
b5ab03b
archive-zip.c: switch to reentrant localtime_r
sgn Nov 28, 2019
7187c7b
t4210: skip i18n tests that don't work on FreeBSD
emaste Nov 27, 2019
72b006f
gpg-interface: prefer check_signature() for GPG verification
illikainen Nov 27, 2019
c64368e
t9001: avoid including non-trailing NUL bytes in variables
bk2204 Nov 27, 2019
867fc7f
grep: don't return an expression from pcre2_free()
illikainen Nov 27, 2019
4d0375c
mingw: do set `errno` correctly when trying to restrict handle inheri…
dscho Nov 30, 2019
0c3944a
add-interactive: make sure to release `rev.prune_data`
dscho Nov 29, 2019
c08171d
built-in add -i: allow filtering the modified files list
dscho Nov 29, 2019
f37c226
built-in add -i: prepare for multi-selection commands
dscho Nov 29, 2019
a8c45be
built-in add -i: implement the `update` command
dscho Nov 29, 2019
c54ef5e
built-in add -i: re-implement `revert` in C
dscho Nov 29, 2019
ab1e1cc
built-in add -i: re-implement `add-untracked` in C
dscho Nov 29, 2019
8746e07
built-in add -i: implement the `patch` command
dscho Nov 29, 2019
d763357
built-in add -i: re-implement the `diff` command
dscho Nov 29, 2019
2e697ce
built-in add -i: offer the `quit` command
dscho Nov 29, 2019
0e07c1c
Merge branch 'jk/cleanup-object-parsing-and-fsck'
gitster Dec 1, 2019
0be5caf
Merge branch 'jc/log-graph-simplify'
gitster Dec 1, 2019
a2b0451
Merge branch 'js/git-path-head-dot-lock-fix'
gitster Dec 1, 2019
fac9ab1
Merge branch 'ma/bisect-doc-sample-update'
gitster Dec 1, 2019
dfc03e4
Merge branch 'mr/clone-dir-exists-to-path-exists'
gitster Dec 1, 2019
532d983
Merge branch 'sg/blame-indent-heuristics-is-now-the-default'
gitster Dec 1, 2019
ecbddd1
Merge branch 'pb/help-list-gitsubmodules-among-guides'
gitster Dec 1, 2019
05fc647
Merge branch 'pb/no-recursive-reset-hard-in-worktree-add'
gitster Dec 1, 2019
5444d52
Merge branch 'js/vreportf-wo-buffering'
gitster Dec 1, 2019
d4924ea
Merge branch 'dl/doc-diff-no-index-implies-exit-code'
gitster Dec 1, 2019
3c90710
Merge branch 'hw/config-doc-in-header'
gitster Dec 1, 2019
f089ddd
Merge branch 'es/myfirstcontrib-updates'
gitster Dec 1, 2019
7ab2088
Merge branch 'rt/fetch-message-fix'
gitster Dec 1, 2019
bad5ed3
Merge branch 'cb/curl-use-xmalloc'
gitster Dec 1, 2019
fc7b26c
Merge branch 'kw/fsmonitor-watchman-fix'
gitster Dec 1, 2019
d08daec
Merge branch 'rs/trace2-dots'
gitster Dec 1, 2019
bcb06e2
Merge branch 'js/fetch-multi-lockfix'
gitster Dec 1, 2019
5149902
Merge branch 'en/misc-doc-fixes'
gitster Dec 1, 2019
ffd130a
Merge branch 'en/t6024-style'
gitster Dec 1, 2019
26f20fa
Merge branch 'ns/test-desc-typofix'
gitster Dec 1, 2019
d3096d2
Merge branch 'en/doc-typofix'
gitster Dec 1, 2019
9a5d34c
Merge branch 'py/shortlog-list-options-for-log'
gitster Dec 1, 2019
376e730
Merge branch 'ln/userdiff-elixir'
gitster Dec 1, 2019
d2489ce
Merge branch 'rs/skip-iprefix'
gitster Dec 1, 2019
ca5c8aa
Merge branch 'rj/bundle-ui-updates'
gitster Dec 1, 2019
a774064
Merge branch 'dj/typofix-merge-strat'
gitster Dec 1, 2019
f165457
Merge branch 'jk/remove-sha1-to-hex'
gitster Dec 1, 2019
6511cb3
Merge branch 'dd/sequencer-utf8'
gitster Dec 1, 2019
43c5fe1
Merge branch 'nn/doc-rebase-merges'
gitster Dec 1, 2019
3c3e5d0
Merge branch 'tg/stash-refresh-index'
gitster Dec 1, 2019
ef8f621
Merge branch 'dl/complete-rebase-onto'
gitster Dec 1, 2019
8faff38
Merge branch 'jk/optim-in-pack-idx-conversion'
gitster Dec 1, 2019
fce9e83
Merge branch 'jt/fetch-remove-lazy-fetch-plugging'
gitster Dec 1, 2019
406ca29
Merge branch 'rs/parse-options-dup-null-fix'
gitster Dec 1, 2019
9da3948
Merge branch 'rs/use-copy-array-in-mingw-shell-command-preparation'
gitster Dec 1, 2019
723a8ad
Merge branch 'ds/test-read-graph'
gitster Dec 1, 2019
4ab9616
Merge branch 'sg/skip-skipped-prereq'
gitster Dec 1, 2019
aec3b2e
Merge branch 'jc/fsmonitor-sanity-fix'
gitster Dec 1, 2019
3ae8def
Merge branch 'jk/send-pack-remote-failure'
gitster Dec 1, 2019
a6c6f8d
Merge branch 'js/complete-svn-recursive'
gitster Dec 1, 2019
4775e02
Merge branch 'ma/t7004'
gitster Dec 1, 2019
3288d99
Merge branch 'ar/install-doc-update-cmds-needing-the-shell'
gitster Dec 1, 2019
6c630f2
Merge branch 'jk/gitweb-anti-xss'
gitster Dec 1, 2019
228f531
The second batch
gitster Dec 1, 2019
e714b89
t7812: expect failure for grep -i with invalid UTF-8 data
tmzullinger Nov 30, 2019
0109d67
mingw: use {gm,local}time_s as backend for {gm,local}time_r
sgn Nov 28, 2019
a4fb016
pkt-line: fix a typo
dscho Dec 2, 2019
3ba3720
mingw: forbid translating ERROR_SUCCESS to an errno value
dscho Dec 2, 2019
ec48540
packfile.c: speed up loading lots of packfiles
ccstolley Nov 27, 2019
10c64a0
Doc: explain submodule.alternateErrorStrategy
jonathantanmy Dec 2, 2019
4f3e57e
submodule--helper: advise on fatal alternate error
jonathantanmy Dec 2, 2019
dcee037
doc: replace MARC links with lore.kernel.org
Denton-L Dec 2, 2019
d23f9c8
RelNotes: replace Gmane with real Message-IDs
Denton-L Dec 2, 2019
14b7664
doc: replace LKML link with lore.kernel.org
Denton-L Dec 2, 2019
ae475af
t7700: consolidate code into test_no_missing_in_packs()
Denton-L Dec 4, 2019
cfe5eda
t7700: consolidate code into test_has_duplicate_object()
Denton-L Dec 4, 2019
dcf9a74
t7700: replace egrep with grep
Denton-L Dec 4, 2019
3699d69
t7700: make references to SHA-1 generic
Denton-L Dec 4, 2019
d9b31db
t7700: stop losing return codes of git commands
Denton-L Dec 4, 2019
0c47e06
t3400: demonstrate failure with format.useAutoBase
Denton-L Dec 4, 2019
a749d01
format-patch: fix indentation
Denton-L Dec 4, 2019
700e006
t4014: use test_config()
Denton-L Dec 4, 2019
945dc55
format-patch: teach --no-base
Denton-L Dec 4, 2019
cae0bc0
rebase: fix format.useAutoBase breakage
Denton-L Dec 4, 2019
0bb313a
xdiff: unignore changes in function context
rscharfe Dec 5, 2019
56d3ce8
Merge branch 'ep/guard-kset-tar-headers'
gitster Dec 5, 2019
917d0d6
Merge branch 'js/rebase-r-safer-label'
gitster Dec 5, 2019
f7998d9
Merge branch 'js/builtin-add-i'
gitster Dec 5, 2019
995b1b1
Merge branch 'dd/rebase-merge-reserves-onto-label'
gitster Dec 5, 2019
76c6824
Merge branch 'ec/fetch-mark-common-refs-trace2'
gitster Dec 5, 2019
9502b61
Merge branch 'jh/userdiff-python-async'
gitster Dec 5, 2019
f3c7bfd
Merge branch 'dl/range-diff-with-notes'
gitster Dec 5, 2019
7fd7a8a
Merge branch 'jc/azure-ci-osx-fix-fix'
gitster Dec 5, 2019
ef61045
Merge branch 'pb/submodule-update-fetches'
gitster Dec 5, 2019
cf91c31
Merge branch 'sg/unpack-progress-throughput'
gitster Dec 5, 2019
36fd304
Merge branch 'jk/fail-show-toplevel-outside-working-tree'
gitster Dec 5, 2019
c920859
Merge branch 'pw/sequencer-compare-with-right-parent-to-check-empty-c…
gitster Dec 5, 2019
f06dff7
Merge branch 'hi/gpg-optional-pkfp-fix'
gitster Dec 5, 2019
75bd003
Merge branch 'js/git-svn-use-rebase-merges'
gitster Dec 5, 2019
57d46bc
Merge branch 'mg/doc-submodule-status-cached'
gitster Dec 5, 2019
6b3cb32
Merge branch 'nl/reset-patch-takes-a-tree'
gitster Dec 5, 2019
8feb47e
Merge branch 'dl/t5520-cleanup'
gitster Dec 5, 2019
88cf809
Merge branch 'mg/submodule-status-from-a-subdirectory'
gitster Dec 5, 2019
e547e5a
Merge branch 'hv/assume-priumax-is-available-anywhere'
gitster Dec 5, 2019
fd95230
Merge branch 'mh/clear-topo-walk-upon-reset'
gitster Dec 5, 2019
e0f9ec9
Merge branch 'sg/test-bool-env'
gitster Dec 5, 2019
473b431
Merge branch 'us/unpack-trees-fsmonitor'
gitster Dec 5, 2019
88bd37a
Merge branch 'js/pkt-line-h-typofix'
gitster Dec 5, 2019
083378c
The third batch
gitster Dec 5, 2019
0f0fba2
t3701: add a test for advanced split-hunk editing
dscho Dec 6, 2019
8539b46
t3701: avoid depending on the TTY prerequisite
dscho Dec 6, 2019
24be352
t3701: add a test for the different `add -p` prompts
dscho Dec 6, 2019
0c3222c
t3701: verify the shown messages when nothing can be added
dscho Dec 6, 2019
e91162b
t3701: verify that the diff.algorithm config setting is handled
dscho Dec 6, 2019
89c8559
git add -p: use non-zero exit code when the diff generation failed
dscho Dec 6, 2019
b4bbbbd
apply --allow-overlap: fix a corner case
dscho Dec 6, 2019
21f5762
t9300-fast-import: store the PID in a variable instead of pidfile
szeder Dec 6, 2019
0d9b0d7
t9300-fast-import: don't hang if background fast-import exits too early
szeder Dec 6, 2019
828765d
t3206: fix incorrect test name
Denton-L Dec 6, 2019
f867534
range-diff: mark pointers as const
Denton-L Dec 6, 2019
abcf857
range-diff: clear `other_arg` at end of function
Denton-L Dec 6, 2019
ef3ce7c
Merge branch 'sg/osx-force-gcc-9'
gitster Dec 6, 2019
f233c9f
Merge branch 'sg/assume-no-todo-update-in-cherry-pick'
gitster Dec 6, 2019
4ba74ca
Merge branch 'rs/test-cleanup'
gitster Dec 6, 2019
92b52e1
Merge branch 'rs/simplify-prepare-cmd'
gitster Dec 6, 2019
391fb22
Merge branch 'rs/use-skip-prefix-more'
gitster Dec 6, 2019
f0cf2fe
Merge branch 'hi/grep-do-not-return-void'
gitster Dec 6, 2019
403ac13
Merge branch 'jk/send-pack-check-negative-with-quick'
gitster Dec 6, 2019
7cb0d37
Merge branch 'tg/perf-remove-stale-result'
gitster Dec 6, 2019
3b3d9ea
Merge branch 'jk/lore-is-the-archive'
gitster Dec 6, 2019
56e6c16
Merge branch 'dl/lore-is-the-archive'
gitster Dec 6, 2019
559c6fc
The fourth batch
gitster Dec 6, 2019
147ee35
commit: use strbuf_add() to add a length-limited string
rscharfe Dec 7, 2019
4507ecc
patch-id: use oid_to_hex() to print multiple object IDs
rscharfe Dec 7, 2019
8cf8f9b
t3404: fix indentation
dscho Dec 7, 2019
11de8dd
l10n: minor case fix in 'git branch' '--unset-upstream' description
DJm00n Dec 8, 2019
e05e8cf
archive-zip: use enum for compression method
rscharfe Dec 7, 2019
7034cd0
Sync with Git 2.24.1
gitster Dec 10, 2019
c58ae96
Merge branch 'am/pathspec-from-file'
gitster Dec 10, 2019
5d9324e
Merge branch 'ra/rebase-i-more-options'
gitster Dec 10, 2019
7c88714
Merge branch 'po/bundle-doc-clonable'
gitster Dec 10, 2019
55d607d
Merge branch 'js/mingw-inherit-only-std-handles'
gitster Dec 10, 2019
99c4ff1
Merge branch 'dl/submodule-set-url'
gitster Dec 10, 2019
d37cfe3
Merge branch 'dl/pretty-reference'
gitster Dec 10, 2019
dac30e7
Merge branch 'as/t7812-missing-redirects-fix'
gitster Dec 10, 2019
5dd1d59
Merge branch 'jt/clone-recursesub-ref-advise'
gitster Dec 10, 2019
41dac79
Merge branch 'ds/commit-graph-delay-gen-progress'
gitster Dec 10, 2019
55c37d1
Merge branch 'jk/perf-wo-git-dot-pm'
gitster Dec 10, 2019
7aba2b7
Merge branch 'sg/test-squelch-noise-in-commit-bulk'
gitster Dec 10, 2019
08d2f46
Merge branch 'bc/t9001-zsh-in-posix-emulation-mode'
gitster Dec 10, 2019
930078b
Merge branch 'hi/gpg-use-check-signature'
gitster Dec 10, 2019
b089e5e
Merge branch 'em/test-skip-regex-illseq'
gitster Dec 10, 2019
7cc5f89
Merge branch 'ag/sequencer-continue-leakfix'
gitster Dec 10, 2019
ad05a3d
The fifth batch
gitster Dec 10, 2019
571fb96
fix-typo: consecutive-word duplications
ryenus Dec 15, 2019
37c2619
Merge branch 'ag/sequencer-todo-updates'
gitster Dec 16, 2019
4755a34
Merge branch 'dd/time-reentrancy'
gitster Dec 16, 2019
3beff38
Merge branch 'js/builtin-add-i-cmds'
gitster Dec 16, 2019
6d831b8
Merge branch 'cs/store-packfiles-in-hashmap'
gitster Dec 16, 2019
c9f5fc9
Merge branch 'dl/test-cleanup'
gitster Dec 16, 2019
71a7de7
Merge branch 'dl/rebase-with-autobase'
gitster Dec 16, 2019
f0070a7
Merge branch 'rs/xdiff-ignore-ws-w-func-context'
gitster Dec 16, 2019
26c816a
Merge branch 'hw/doc-in-header'
gitster Dec 16, 2019
d1c0fe8
Merge branch 'dl/range-diff-with-notes'
gitster Dec 16, 2019
011fc2e
Merge branch 'js/add-i-a-bit-more-tests'
gitster Dec 16, 2019
8bc481f
Merge branch 'sg/t9300-robustify'
gitster Dec 16, 2019
3a44db2
Merge branch 'dr/branch-usage-casefix'
gitster Dec 16, 2019
4438a1a
Merge branch 'js/t3404-indent-fix'
gitster Dec 16, 2019
43bf44e
Merge branch 'rs/archive-zip-code-cleanup'
gitster Dec 16, 2019
e3b7239
Merge branch 'rs/commit-export-env-simplify'
gitster Dec 16, 2019
59d0b3b
Merge branch 'rs/patch-id-use-oid-to-hex'
gitster Dec 16, 2019
b02fd2a
The sixth batch
gitster Dec 16, 2019
12029dc
t3434: mark successful test as such
newren Dec 13, 2019
420cda2
config: fix typo in variable name
ROGERSM94 Dec 20, 2019
24eec91
config: fix config scope enum
ROGERSM94 Dec 20, 2019
066d944
config: add '--show-scope' to print the scope of a config value
ROGERSM94 Dec 20, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions Documentation/CodingGuidelines
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ For shell scripts specifically (not exhaustive):

- If you want to find out if a command is available on the user's
$PATH, you should use 'type <command>', instead of 'which <command>'.
The output of 'which' is not machine parseable and its exit code
The output of 'which' is not machine parsable and its exit code
is not reliable across platforms.

- We use POSIX compliant parameter substitutions and avoid bashisms;
Expand Down Expand Up @@ -203,7 +203,7 @@ For C programs:
. since early 2012 with e1327023ea, we have been using an enum
definition whose last element is followed by a comma. This, like
an array initializer that ends with a trailing comma, can be used
to reduce the patch noise when adding a new identifer at the end.
to reduce the patch noise when adding a new identifier at the end.

. since mid 2017 with cbc0f81d, we have been using designated
initializers for struct (e.g. "struct t v = { .val = 'a' };").
Expand Down
1 change: 1 addition & 0 deletions Documentation/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ API_DOCS = $(patsubst %.txt,%,$(filter-out technical/api-index-skel.txt technica
SP_ARTICLES += $(API_DOCS)

TECH_DOCS += MyFirstContribution
TECH_DOCS += MyFirstObjectWalk
TECH_DOCS += SubmittingPatches
TECH_DOCS += technical/hash-function-transition
TECH_DOCS += technical/http-protocol
Expand Down
55 changes: 51 additions & 4 deletions Documentation/MyFirstContribution.txt
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,26 @@ $ git clone https://github.com/git/git git
$ cd git
----

[[dependencies]]
=== Installing Dependencies

To build Git from source, you need to have a handful of dependencies installed
on your system. For a hint of what's needed, you can take a look at
`INSTALL`, paying close attention to the section about Git's dependencies on
external programs and libraries. That document mentions a way to "test-drive"
our freshly built Git without installing; that's the method we'll be using in
this tutorial.

Make sure that your environment has everything you need by building your brand
new clone of Git from the above step:

----
$ make
----

NOTE: The Git build is parallelizable. `-j#` is not included above but you can
use it as you prefer, here and elsewhere.

[[identify-problem]]
=== Identify Problem to Solve

Expand Down Expand Up @@ -138,9 +158,6 @@ NOTE: When you are developing the Git project, it's preferred that you use the
`DEVELOPER` flag; if there's some reason it doesn't work for you, you can turn
it off, but it's a good idea to mention the problem to the mailing list.

NOTE: The Git build is parallelizable. `-j#` is not included above but you can
use it as you prefer, here and elsewhere.

Great, now your new command builds happily on its own. But nobody invokes it.
Let's change that.

Expand Down Expand Up @@ -534,6 +551,28 @@ you want to pass as a parameter something which would usually be interpreted as
a flag.) `parse_options()` will terminate parsing when it reaches `--` and give
you the rest of the options afterwards, untouched.

Now that you have a usage hint, you can teach Git how to show it in the general
command list shown by `git help git` or `git help -a`, which is generated from
`command-list.txt`. Find the line for 'git-pull' so you can add your 'git-psuh'
line above it in alphabetical order. Now, we can add some attributes about the
command which impacts where it shows up in the aforementioned help commands. The
top of `command-list.txt` shares some information about what each attribute
means; in those help pages, the commands are sorted according to these
attributes. `git psuh` is user-facing, or porcelain - so we will mark it as
"mainporcelain". For "mainporcelain" commands, the comments at the top of
`command-list.txt` indicate we can also optionally add an attribute from another
list; since `git psuh` shows some information about the user's workspace but
doesn't modify anything, let's mark it as "info". Make sure to keep your
attributes in the same style as the rest of `command-list.txt` using spaces to
align and delineate them:

----
git-prune-packed plumbingmanipulators
git-psuh mainporcelain info
git-pull mainporcelain remote
git-push mainporcelain remote
----

Build again. Now, when you run with `-h`, you should see your usage printed and
your command terminated before anything else interesting happens. Great!

Expand Down Expand Up @@ -746,6 +785,14 @@ will automatically run your PRs through the CI even without the permission given
but you will not be able to `/submit` your changes until someone allows you to
use the tool.

NOTE: You can typically find someone who can `/allow` you on GitGitGadget by
either examining recent pull requests where someone has been granted `/allow`
(https://github.com/gitgitgadget/git/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+%22%2Fallow%22[Search:
is:pr is:open "/allow"]), in which case both the author and the person who
granted the `/allow` can now `/allow` you, or by inquiring on the
https://webchat.freenode.net/#git-devel[#git-devel] IRC channel on Freenode
linking your pull request and asking for someone to `/allow` you.

If the CI fails, you can update your changes with `git rebase -i` and push your
branch again:

Expand Down Expand Up @@ -970,7 +1017,7 @@ reviewers the changes you've made that may not be as visible.
You will also need to go and find the Message-Id of your previous cover letter.
You can either note it when you send the first series, from the output of `git
send-email`, or you can look it up on the
https://public-inbox.org/git[mailing list]. Find your cover letter in the
https://lore.kernel.org/git[mailing list]. Find your cover letter in the
archives, click on it, then click "permalink" or "raw" to reveal the Message-Id
header. It should match:

Expand Down
Loading