Skip to content

Accommodate for vcpkg's upgrade to OpenSSL v1.1.x #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dscho
Copy link
Member

@dscho dscho commented Jan 15, 2020

This fixes #2474.

With the upgrade, the library names changed from libeay32/ssleay32 to
libcrypto/libssl.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho marked this pull request as ready for review January 15, 2020 13:52
@dscho
Copy link
Member Author

dscho commented Jan 15, 2020

I would actually much prefer to have a dynamic check in the .vcxproj files that defines a constant to libcrypto.lib or libeay32.lib depending which one is available. But I lack the time to investigate that right now.

@dscho dscho merged commit f92c7e0 into git-for-windows:master Jan 15, 2020
git-for-windows-ci pushed a commit that referenced this pull request Jan 15, 2020
Accommodate for vcpkg's upgrade to OpenSSL v1.1.x
git-for-windows-ci pushed a commit that referenced this pull request Jan 16, 2020
Accommodate for vcpkg's upgrade to OpenSSL v1.1.x
git-for-windows-ci pushed a commit that referenced this pull request Jan 16, 2020
Accommodate for vcpkg's upgrade to OpenSSL v1.1.x
git-for-windows-ci pushed a commit that referenced this pull request Jan 16, 2020
Accommodate for vcpkg's upgrade to OpenSSL v1.1.x
derrickstolee added a commit to microsoft/git that referenced this pull request Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LINK : fatal error LNK1181: cannot open input file 'libeay32.lib'
1 participant