Skip to content

git-artifacts: add workaround for GCM Core on ARM64 #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dennisameling
Copy link

@dennisameling dennisameling commented Mar 3, 2021

Closes #3015

Adds a workaround for Git Credential Manager Core to the git-artifacts.yml CI workflow, as discussed in #3015 (comment)

Test run in progress: https://github.com/dennisameling/git/actions/runs/617373202

@dennisameling dennisameling force-pushed the git-credential-manager-core-arm64 branch from d20318c to 321ccc0 Compare March 3, 2021 11:28
@dscho
Copy link
Member

dscho commented Mar 3, 2021

Would you mind replacing the ci: prefix by a git-artifacts: one? This is not the Continuous Integration workflow we're talking about, after all.

(And if you force-push that commit message-only fix after the PR builds succeeded, the next PR build will pick up on the build and skip re-running everything.)

Otherwise, it looks good to me!

@dennisameling
Copy link
Author

dennisameling commented Mar 3, 2021

I think #3053 will need to be merged prior to this one, as you mentioned you fixed the ARM64 build in that PR @dscho. My workflow failed at least: https://github.com/dennisameling/git/actions/runs/617373202

Will fix the commit now 👍🏼

@dennisameling dennisameling force-pushed the git-credential-manager-core-arm64 branch 2 times, most recently from bce0593 to 775f055 Compare March 3, 2021 12:04
@dennisameling dennisameling changed the title ci: add workaround for GCM Core on ARM64 git-artifacts: add workaround for GCM Core on ARM64 Mar 3, 2021
Since there is no GCM Core for ARM64, let's just install a simple shell
script that calls the i686 version for now.

Signed-off-by: Dennis Ameling <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho force-pushed the git-credential-manager-core-arm64 branch from 775f055 to 6686bba Compare March 5, 2021 22:00
@dscho dscho added this to the Next release milestone Mar 5, 2021
@dscho dscho merged commit 92b3d7c into git-for-windows:main Mar 5, 2021
dscho added a commit that referenced this pull request Mar 6, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Mar 6, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Mar 6, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Mar 6, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Mar 8, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Mar 8, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Mar 8, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Mar 8, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Mar 8, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit to dscho/git that referenced this pull request Mar 9, 2021
…tial-manager-core-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Mar 10, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Mar 10, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Mar 10, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Mar 10, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Mar 10, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Mar 10, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Mar 10, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Mar 10, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Aug 2, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit to dscho/git that referenced this pull request Aug 3, 2021
…tial-manager-core-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Aug 3, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Aug 3, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Aug 3, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Aug 3, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Aug 4, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Aug 4, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Aug 4, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Aug 4, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Aug 4, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Aug 4, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Aug 6, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Aug 6, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Aug 6, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Aug 11, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Aug 13, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Aug 18, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Aug 23, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Aug 24, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Aug 31, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Sep 8, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Sep 13, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Oct 4, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Oct 12, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Oct 12, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
dscho added a commit that referenced this pull request Oct 13, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Oct 13, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Oct 13, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
git-for-windows-ci pushed a commit that referenced this pull request Oct 13, 2021
…re-arm64

git-artifacts: add workaround for GCM Core on ARM64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git Credential Manager Core missing in ARM64 libexec folder
2 participants