mingw: allow for longer paths in parse_interpreter()
#3165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in newren/git-filter-repo#225, it looks like 99 bytes is not really sufficient to represent e.g. the full path to Python when installed via Windows Store (and this path is used in the hasb bang line when installing scripts via `pip`). Let's increase it to what is probably the maximum sensible path size: 248 (the same as for `CreateDirectory()`). Signed-off-by: Johannes Schindelin <[email protected]>
derrickstolee
approved these changes
Apr 2, 2021
derrickstolee
left a comment
derrickstolee
left a comment
There was a problem hiding this comment.
Arbitrary limits are dangerous, but it seems you have a similar limit elsewhere.
newren
approved these changes
Apr 2, 2021
newren
left a comment
newren
left a comment
There was a problem hiding this comment.
Sweet, thanks for digging in to this!
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 3, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 3, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 3, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
|
Good fix! Since Git for Windows has long path support why not increase this to MAX_PATH or even MAX_LONG_PATH? EDIT: at least make it in-line with code below Line 1524 in 8b8cd53 |
Member
Author
Sure, go ahead! |
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 4, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 4, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 4, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 4, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 4, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 4, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 6, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 6, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 6, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 6, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 6, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 7, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 7, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
dscho
added a commit
that referenced
this pull request
Apr 7, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 7, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 8, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
dscho
added a commit
that referenced
this pull request
Apr 8, 2021
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 4, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 4, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 5, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 5, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 5, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 6, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 6, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
dscho
added a commit
that referenced
this pull request
Nov 6, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 6, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 6, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 6, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 6, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 6, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 6, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 7, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 8, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 8, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
dscho
added a commit
that referenced
this pull request
Nov 10, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
dscho
added a commit
that referenced
this pull request
Nov 10, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 10, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 12, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 12, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 12, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 12, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 12, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
dscho
added a commit
that referenced
this pull request
Nov 12, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 12, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 12, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 12, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 12, 2025
…reter-path mingw: allow for longer paths in `parse_interpreter()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in newren/git-filter-repo#225, it looks like 99 bytes is not really sufficient to represent e.g. the full path to Python when installed via Windows Store (and this path is used in the hasb bang line when installing scripts via
pip).Let's increase it to what is probably the maximum sensible path size: 248 (the same as for
CreateDirectory()).