Fixed masking username with asterisks when reading credentials#677
Merged
dscho merged 1 commit intogit-for-windows:masterfrom Mar 2, 2016
Merged
Fixed masking username with asterisks when reading credentials#677dscho merged 1 commit intogit-for-windows:masterfrom
dscho merged 1 commit intogit-for-windows:masterfrom
Conversation
Member
|
Thank you for your contribution! I would like to suggest two changes, both with the commit message:
Could you amend the commit and force-push? |
When user is asked for credentials there is no need to mask username, so PROMPT_ASKPASS flag on calling credential_ask_one for login is unnecessary. credential_ask_one internally uses git_prompt which in case of given flag PROMPT_ASKPASS uses masked input method instead of git_terminal_prompt, which does not mask user input. This fixes git-for-windows#675 Signed-off-by: yaras <yaras6@gmail.com>
Author
|
I updated commit message. Could you check it? |
dscho
added a commit
that referenced
this pull request
Mar 2, 2016
Fixed masking username with asterisks when reading credentials
Member
|
Perfect, thanks! |
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Mar 2, 2016
We [no longer show asterisks when reading the username for credentials](git-for-windows/git#677). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
that referenced
this pull request
Mar 15, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Mar 18, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Mar 29, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Apr 4, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Apr 30, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
May 20, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Jun 7, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Jun 9, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Jun 9, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Jun 9, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Jun 9, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Jun 14, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Jul 12, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Jul 16, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Jul 23, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Jul 23, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Jul 23, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Jul 27, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Jul 27, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Jul 29, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Aug 2, 2016
Fixed masking username with asterisks when reading credentials
dscho
pushed a commit
that referenced
this pull request
Aug 6, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Aug 10, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Aug 10, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Aug 11, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Aug 11, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Aug 12, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Aug 12, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Aug 13, 2016
Fixed masking username with asterisks when reading credentials
dscho
pushed a commit
that referenced
this pull request
Aug 13, 2016
Fixed masking username with asterisks when reading credentials
dscho
pushed a commit
that referenced
this pull request
Aug 13, 2016
Fixed masking username with asterisks when reading credentials
dscho
pushed a commit
that referenced
this pull request
Aug 13, 2016
Fixed masking username with asterisks when reading credentials
dscho
pushed a commit
that referenced
this pull request
Aug 15, 2016
Fixed masking username with asterisks when reading credentials
dscho
pushed a commit
that referenced
this pull request
Aug 15, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Aug 15, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Aug 15, 2016
Fixed masking username with asterisks when reading credentials
dscho
pushed a commit
that referenced
this pull request
Aug 20, 2016
Fixed masking username with asterisks when reading credentials
dscho
pushed a commit
that referenced
this pull request
Aug 20, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Aug 22, 2016
Fixed masking username with asterisks when reading credentials
dscho
added a commit
that referenced
this pull request
Aug 22, 2016
Fixed masking username with asterisks when reading credentials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #675
When reading username PROMPT_ASKPASS is unnecessary.
Signed-off-by: yaras yaras6@gmail.com
After my change, username is asked in command prompt (without asterisks) and user password in Open SSH prompt (with asterisks).
What you think about such solution?