fixup! name-hash: precompute hash values during preload-index #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear the precompute flag in create_alias_ce(). It might be possible to use the precompute_ fields from the alias in the new one, but its not worth the bother. Signed-off-by: Jeff Hostetler <[email protected]>
|
@dscho Good catch on the fixup for the rename case. I think this one should go with that. |
dscho
approved these changes
Nov 23, 2016
| @@ -616,6 +616,7 @@ static struct cache_entry *create_alias_ce(struct index_state *istate, | |||
| new = xcalloc(1, cache_entry_size(len)); | |||
| memcpy(new->name, alias->name, len); | |||
| copy_cache_entry(new, ce); | |||
| new->precompute_hash_state = 0; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear the precompute flag in create_alias_ce().
It might be possible to use the precompute_ fields from the
alias in the new one, but its not worth the bother.
Signed-off-by: Jeff Hostetler [email protected]