Assorted fixes for Git for windows #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is true that pure Windows programs cannot handle the TZ variable well. However, the same is not true of Git, which handles the timezone environment variable quite well. Let's give it a chance by passing on the TZ environment variable as MSYS2_TZ. Signed-off-by: Johannes Schindelin <[email protected]>
This resembles MSys1' behavior on which Git's t0060 relies. Signed-off-by: Johannes Schindelin <[email protected]>
Git's test suite most prominently sports a POSIX path with a space in it: the tests are executed in directories whose names have the form 'trash directory.t0123-blub'. Therefore, we *must* handle those names correctly. This fix makes Git's t1504-ceiling-dirs.sh pass. Signed-off-by: Johannes Schindelin <[email protected]>
There is a difference between an empty value and an unset environment variable. We should not confuse both; If the user wants to unset an environment variable, they can certainly do so (unsetenv(3), or in the shell: 'unset ABC'). This fixes Git's t3301-notes.sh, which overrides environment variables with empty values. Signed-off-by: Johannes Schindelin <[email protected]>
Even when the character set is specified as ASCII, we should handle data outside the 7-bit range gracefully by simply copying it, even if it is technically no longer ASCII. This fixes several of Git for Windows' tests, e.g. t7400. Signed-off-by: Johannes Schindelin <[email protected]>
It came in real handy while debugging an issue that strace 'fixed'. Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
It is not a good idea to expand, say, ~/.gitconfig partially: replacing it by ~C:\msys64\.gitconfig is most likely the wrong thing to do! Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
We do not perform tilde expansion in the MSys2 runtime; let's leave those paths intact for programs that want to expand such paths themselves. Signed-off-by: Johannes Schindelin <[email protected]>
The substring '::' most likely denotes an IPv6 address, not a path. Signed-off-by: Johannes Schindelin <[email protected]>
This fixes Git's t1506-rev-parse-diagnosis.sh Signed-off-by: Johannes Schindelin <[email protected]>
... so let's skip posix-to-windows conversion on such parameters. This fixes Git's t1508-at-combinations.sh. Signed-off-by: Johannes Schindelin <[email protected]>
An argument like [email protected]:/tmp/ is not something we should convert into a Windows path; Use the absence of a slash before the colon as a tell-tale that it is *not* a POSIX path list (exception: if the part left of the colon is "." or ".."). Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
git-for-windows
branch
from
ca0293f to
aefedc0
Compare
dscho
force-pushed
the
git-for-windows
branch
from
aefedc0 to
379db4b
Compare
dscho
added a commit
that referenced
this pull request
Feb 22, 2015
Assorted fixes for Git for windows
dscho
added a commit
that referenced
this pull request
Apr 22, 2015
Assorted fixes for Git for windows
dscho
added a commit
that referenced
this pull request
Apr 23, 2015
Assorted fixes for Git for windows
dscho
added a commit
that referenced
this pull request
May 5, 2015
Assorted fixes for Git for windows
dscho
added a commit
that referenced
this pull request
May 24, 2015
Assorted fixes for Git for windows
dscho
added a commit
that referenced
this pull request
Jun 28, 2015
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Aug 28, 2015
Assorted fixes for Git for windows
dscho
added a commit
that referenced
this pull request
Sep 16, 2015
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Nov 25, 2015
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Apr 8, 2021
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Nov 11, 2021
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Dec 3, 2021
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Feb 1, 2022
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
May 3, 2022
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
May 6, 2022
Assorted fixes for Git for windows
dscho
added a commit
that referenced
this pull request
May 8, 2022
Assorted fixes for Git for windows
dscho
added a commit
that referenced
this pull request
May 8, 2022
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
May 13, 2022
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Sep 5, 2022
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
May 12, 2023
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Jun 16, 2023
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Jun 19, 2023
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Sep 6, 2023
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Nov 29, 2023
Assorted fixes for Git for windows
dscho
pushed a commit
to dscho/msys2-runtime
that referenced
this pull request
Feb 25, 2024
No longer drop ranges of identical link names. Append '#0, git-for-windows#1, ...' to each name instead. Enhance charset allowed in label names. No longer ignore null volume serial numbers. Signed-off-by: Christian Franke <[email protected]>
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Aug 30, 2024
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Sep 5, 2024
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Sep 18, 2024
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Dec 24, 2024
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Jan 26, 2025
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Jan 26, 2025
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Jan 26, 2025
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Jan 27, 2025
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Jan 28, 2025
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Jan 30, 2025
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Mar 21, 2025
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Mar 21, 2025
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Apr 9, 2025
Assorted fixes for Git for windows
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Apr 9, 2025
Assorted fixes for Git for windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git for Windows is about to switch to an MSys2-based development environment. The major road block was that the test suite did not pass when building Git in such an environment.
These changes are required to support Git for Windows, and together with a couple more commits to Git for Windows' own source code, makes the test suite pass.