Skip to content

Conversation

@dyrone
Copy link

@dyrone dyrone commented Mar 7, 2025

Thanks for taking the time to contribute to Git! Please be advised that the
Git community does not use github.com for their contributions. Instead, we use
a mailing list ([email protected]) for code submissions, code reviews, and
bug reports. Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.

For a single-commit pull request, please leave the pull request description
empty
: your commit message itself should describe your changes.

Please read the "guidelines for contributing" linked above!

@github-actions
Copy link

github-actions bot commented Mar 7, 2025

Errors and warnings found by git-po-helper in workflow #934:

------------------------------------------------------------------------------
ERROR [po/zh_CN.po@c20da80]	/tmp/1854552521--zh_CN.po:22608: number of format specifications in 'msgid' and 'msgstr' does not match 
ERROR [po/zh_CN.po@c20da80]	/usr/bin/msgfmt: found 1 fatal error 
ERROR [po/zh_CN.po@c20da80]	5836 translated messages. 
ERROR [po/zh_CN.po@c20da80]	fail to check po: exit status 1 
INFO checking commits: 0 passed, 1 failed.        
------------------------------------------------------------------------------
INFO downloading pot file from https://github.com/git-l10n/pot-changes/raw/pot/master/po/git.pot 

ERROR: fail to execute "git-po-helper check-commits"

@jiangxin
Copy link
Member

jiangxin commented Mar 9, 2025

尝试使用 Claude 帮助做下评审:

  1. 一些专业术语翻译不够统一:

    -"rev" 有时翻译为"版本",有时保留为英文
    +建议统一翻译为"版本"

  2. 个别翻译不够准确:

    msgid "toggle inclusion of tag objects"
    -msgstr "奇幻是否包含标签对象"
    +msgstr "切换是否包含标签对象"

  3. 有一处格式问题:

    msgid " <%s>"
    -msgstr " <%s"
    +msgstr " <%s>"
    缺少了结尾的">"

  4. 建议添加一些注释说明较复杂的翻译选择

  5. 少数长句的断行可以优化,以提高可读性

建议修复这些问题后再次提交。总的来说这是一个高质量的本地化工作。

建议后续工作:

  1. 建立术语表确保专业术语翻译统一
  2. 考虑添加翻译注释
  3. 做更多测试确保格式正确

@dyrone dyrone force-pushed the tl/zh_CN_2.49.0_rnd branch from 1131bf9 to 34b63d3 Compare March 9, 2025 12:36
@dyrone
Copy link
Author

dyrone commented Mar 9, 2025

尝试使用 Claude 帮助做下评审:

  1. 一些专业术语翻译不够统一:
    -"rev" 有时翻译为"版本",有时保留为英文
    +建议统一翻译为"版本"

rev 看起来是历史的一些翻译造成,目前计划暂时不做改动

  1. 个别翻译不够准确:
    msgid "toggle inclusion of tag objects"
    -msgstr "奇幻是否包含标签对象"
    +msgstr "切换是否包含标签对象"

Typo造成,下个提交将修复

  1. 有一处格式问题:
    msgid " <%s>"
    -msgstr " <%s"
    +msgstr " <%s>"
    缺少了结尾的">"
  2. 建议添加一些注释说明较复杂的翻译选择
  3. 少数长句的断行可以优化,以提高可读性

编辑错误,下个提交将修复

建议修复这些问题后再次提交。总的来说这是一个高质量的本地化工作。

建议后续工作:

  1. 建立术语表确保专业术语翻译统一
  2. 考虑添加翻译注释
  3. 做更多测试确保格式正确

@dyrone dyrone force-pushed the tl/zh_CN_2.49.0_rnd branch from 34b63d3 to 6dded64 Compare March 9, 2025 13:54
Copy link

@fangyi-zhou fangyi-zhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢翻译!

@dyrone dyrone force-pushed the tl/zh_CN_2.49.0_rnd branch from 6dded64 to 991b252 Compare March 10, 2025 02:20
@dyrone
Copy link
Author

dyrone commented Mar 10, 2025

image
image

我用 Claude3.7 分析了下, 有几个问题我改掉了。

里面提的两点意见听上去不错:

  • 第一个:是使用”您“来替换”你“,这个我们可以考虑都替换掉。
  • 第二个:在翻译技术术语时,可以考虑在首次出现时使用"中文(英文)"的形式。从我的视角来看,这个效果确实比单独的晦涩中文翻译稍微好一些,我们也可以考虑后续慢慢替换。
    image

@dyrone dyrone force-pushed the tl/zh_CN_2.49.0_rnd branch from 991b252 to 7dc8d12 Compare March 10, 2025 03:27
@dyrone dyrone force-pushed the tl/zh_CN_2.49.0_rnd branch 5 times, most recently from fa6c9b1 to 3549f3b Compare March 11, 2025 04:37
@dyrone
Copy link
Author

dyrone commented Mar 11, 2025

@jiangxin jiangxin changed the title Tl/zh cn 2.49.0 rnd WIP: Tl/zh cn 2.49.0 rnd Mar 11, 2025
@jiangxin jiangxin marked this pull request as draft March 11, 2025 05:40
@jiangxin jiangxin changed the title WIP: Tl/zh cn 2.49.0 rnd Tl/zh cn 2.49.0 rnd Mar 11, 2025
Copy link
Member

@jiangxin jiangxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

找到一些待优化点。

@dyrone dyrone force-pushed the tl/zh_CN_2.49.0_rnd branch 2 times, most recently from e63dd16 to 46d0850 Compare March 12, 2025 06:04
@dyrone
Copy link
Author

dyrone commented Mar 12, 2025

找到一些待优化点。

已修复/优化

Helped-by: 依云 <[email protected]>
Helped-by: Jiang Xin <[email protected]>
Signed-off-by: Teng Long <[email protected]>
@dyrone dyrone force-pushed the tl/zh_CN_2.49.0_rnd branch from 46d0850 to ed99a5d Compare March 12, 2025 06:53
@jiangxin
Copy link
Member

看到评论均已响应,并且 #840 也做了回复,本 PR 可以合入,请取消草稿状态。

@jiangxin jiangxin merged commit 4d53aae into git-l10n:master Mar 12, 2025
3 checks passed
@dyrone
Copy link
Author

dyrone commented Mar 12, 2025

谢谢 @jiangxin @lilydjwg 的耐心review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants