-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Impact on the git-scm site if ProGit2 English book changes default branch from master
to main
?
#1501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@HonkingGoose Thanks for the heads-up! The main interaction with progit2 repositories is via a nightly job. And it looks like it does refer to It's also not that big a deal if the job is broken for a day or two (the site would continue to work; we just wouldn't pull new nightly updates). So if we have to just coordinate a flip-over of |
This wasn't quite as trivial as I'd expected, but wasn't too bad: #1502. Once that's merged, then I think we should continue to do the right thing even if the progit2 repo switches its default branch. |
On git-scm build process.Checking if I understand your site-build process correctly:
What process should ProGit2 follow with regards to git-scm?
Can you please say what you would like us (ProGit2) to do? That way I can put it in the checklist to increase the chance of a smooth move. 😄 👍 About pulling from translation repositories, per-repo notion of main branch?I'm not sure what you mean here:
|
@HonkingGoose I've merged #1502, so I think everything should just work automatically now if you change branch names. When you do, it's probably worth double-checking that any changes that came after the branch name change are reflected on the site after 24 hours. But I don't think we need to otherwise coordinate from here out. As you noted, the book links just point directly to the release files, so I don't think we should need any change there.
We use that same code to pull updates from progit2/progit2 as well as translation repositories (listed here). If we just swapped out I'm going to close this, because I don't think there are any further steps on our side. Thanks again for letting us know. I think the only thing to put on your checklist is confirming that book changes continue to get picked up even after the branch changes. |
Hi @peff, thanks for your explanations on how it works at your end! 👍 I've updated my checklist at progit/progit2#1463 to include your advice. Thanks again for your kind words, and for your help! 👍 😄 |
src/KX11/KenticoCleanUpWebFarmServersAndTasks.v11.sql |
|
I've been figuring out what it would take to change the ProGit2 project's default branch from
master
tomain
. I've done a lot of preparatory work already. But I still want to check with you guys what the impact on your end would be. 😉I made a basic "checklist" issue at progit/progit2#1463, and opened a ProGit2 pull with the necessary changes to their build process at progit/progit2#1464.
Questions:
master
branch?master
branch?The text was updated successfully, but these errors were encountered: