Skip to content

Fix CI/PR failures in the "Documentation" job #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dscho
Copy link
Member

@dscho dscho commented Feb 9, 2020

It would probably make sense to apply this to maint, too, as it will cause CI failures even if there is nothing actionable to be done to really fix this on Git's side.

A recent update in the Linux VM images used by Azure Pipelines surfaced
a new problem in the "Documentation" job. Apparently, this warning
appears 396 times on `stderr` when running `make doc`:

/usr/lib/ruby/vendor_ruby/rubygems/defaults/operating_system.rb:10: warning: constant Gem::ConfigMap is deprecated

This problem was already reported to the `rubygems` project via
rubygems/rubygems#3068.

As there is nothing Git can do about this warning, and as the
"Documentation" job reports this warning as a failure, let's just
silence it and move on.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho force-pushed the workaround-for-rubygems-using-deprecated-component branch from c74fa46 to be59f18 Compare February 9, 2020 21:23
@dscho
Copy link
Member Author

dscho commented Feb 9, 2020

/submit

@gitgitgadget-git
Copy link

Submitted as [email protected]

@gitgitgadget-git
Copy link

On the Git mailing list, Taylor Blau wrote (reply to this):

Hi Johannes,

On Sun, Feb 09, 2020 at 10:36:16PM +0000, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <[email protected]>
>
> A recent update in the Linux VM images used by Azure Pipelines surfaced
> a new problem in the "Documentation" job. Apparently, this warning
> appears 396 times on `stderr` when running `make doc`:
>
> /usr/lib/ruby/vendor_ruby/rubygems/defaults/operating_system.rb:10: warning: constant Gem::ConfigMap is deprecated
>
> This problem was already reported to the `rubygems` project via
> https://github.com/rubygems/rubygems/issues/3068.
>
> As there is nothing Git can do about this warning, and as the
> "Documentation" job reports this warning as a failure, let's just
> silence it and move on.

Thanks for explaining, and for taking time to silence errors such as
these that we can't do anything about. Everything as explained makes
good sense to me.

> Signed-off-by: Johannes Schindelin <[email protected]>
> ---
>     Fix CI/PR failures in the "Documentation" job
>
>     It would probably make sense to apply this to maint, too, as it will
>     cause CI failures even if there is nothing actionable to be done to
>     really fix this on Git's side.
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-707%2Fdscho%2Fworkaround-for-rubygems-using-deprecated-component-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-707/dscho/workaround-for-rubygems-using-deprecated-component-v1
> Pull-Request: https://github.com/git/git/pull/707
>
>  ci/test-documentation.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ci/test-documentation.sh b/ci/test-documentation.sh
> index b3e76ef863..de41888430 100755
> --- a/ci/test-documentation.sh
> +++ b/ci/test-documentation.sh
> @@ -7,6 +7,7 @@
>
>  filter_log () {
>  	sed -e '/^GIT_VERSION = /d' \
> +	    -e "/constant Gem::ConfigMap is deprecated/d" \
>  	    -e '/^    \* new asciidoc flags$/d' \
>  	    -e '/stripped namespace before processing/d' \
>  	    -e '/Attributed.*IDs for element/d' \
>
> base-commit: d0654dc308b0ba76dd8ed7bbb33c8d8f7aacd783
> --
> gitgitgadget

Thanks,
Taylor

@gitgitgadget-git
Copy link

This branch is now known as js/ci-squelch-doc-warning.

@gitgitgadget-git
Copy link

This patch series was integrated into pu via db280cc.

@gitgitgadget-git gitgitgadget-git bot added the pu label Feb 10, 2020
@gitgitgadget-git
Copy link

This patch series was integrated into pu via 2c51ec0.

@gitgitgadget-git
Copy link

This patch series was integrated into pu via c47d377.

@gitgitgadget-git
Copy link

This patch series was integrated into next via 4fec291.

@gitgitgadget-git
Copy link

This patch series was integrated into pu via 0de2d14.

@gitgitgadget-git
Copy link

This patch series was integrated into next via 0de2d14.

@gitgitgadget-git
Copy link

This patch series was integrated into master via 0de2d14.

@gitgitgadget-git
Copy link

Closed via 0de2d14.

@dscho dscho deleted the workaround-for-rubygems-using-deprecated-component branch February 13, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant