-
Notifications
You must be signed in to change notification settings - Fork 605
feat: update [email protected].*
+ @sveltejs/[email protected]
#4056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: more eslint svelte5 errors fix: more eslint fixes
3dd88e8
to
45e9ab7
Compare
fix: more Modal cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update
svelte
and@sveltejs/kit
to their latest versionsRefactor out the usage of
SLOTS = $$props.$$slots
Components are no longer classes under the hood, therefore refactored out the few
new Component
instantiations to use themount
import fromsvelte
insteadCommitMessageInput
was throwing an error regarding it's use of the ResizeObserver ("loop completed with undelivered messages"), with a bit of simplification it doesn't seem like theuseResize
action was necessary in the textareas/textinputs. The preexisting event handlers adjusting the input's heightoninput
oronchange
were enough, so I removed theuse:useResize
action on those components.Upgraded the
@sentry/sveltekit
package<-- svelte-ignore ..
options now aresnake_case
instead ofkebab-case
Example Convert
<Modal />
component to svelte 5$props()
instead ofexport let ..
onclose
prop / function instead ofcreateEventDispatcher
anddispatch('close' ...)
#snippets
instead of<slots />
<form />
in Modal body and therefore also rm the implicit relationship withtype="submit"
buttons in favor of explicitonclick
handlers on those submit btnssvelte-check / eslint now complains about the following, so I cleaned these up:
$page is an invalid variable
- seems to be something that's just not supported in eslint-plugin-svelte yet so Idisable-next-line
-ed it for nowtinykeys
, so I added a dummy module declaration to the rootapp.d.ts
<div />
-><div></div>
)Action
enum inPullRequestButton.svelte
, so updated that to anas const
objectTodos
#snippet
usage when passing arguments to the nameless default snippet, i.e.children
. Do you pick up those arguments like in v4? (<Modal ... let:items />
)?Notes