-
Notifications
You must be signed in to change notification settings - Fork 141
status: remove the empty line after hints #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
status: remove the empty line after hints #196
Conversation
136ad4e
to
468be8f
Compare
Welcome to GitGitGadgetHi @johnlinp, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests. Please make sure that this Pull Request has a good description, as it will be used as cover letter. Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:
It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code. Contributing the patchesBefore you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a PR comment of the form Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions. If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox ("raw") file corresponding to the mail you want to reply to from the Git mailing list. If you use GMail, you can upload that raw mbox file via: curl -g --user "<EMailAddress>:<Password>" --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt |
/allow johnlinp |
User johnlinp is now allowed to use GitGitGadget. |
Thank you @dscho! |
/submit |
Submitted as [email protected] |
You're welcome! (In more than one sense 😄 ) |
Before this patch, there is inconsistency between the status messages with hints and the ones without hints: there is an empty line between the title and the file list if hints are presented, but there isn't one if there are no hints. This patch remove the inconsistency by removing the empty lines even if hints are presented. Signed-off-by: John Lin <[email protected]>
468be8f
to
7dfb9a4
Compare
/submit |
Error: Refusing to submit a patch series that does not merge cleanly. |
/submit |
Submitted as [email protected] |
This branch is now known as |
This patch series was integrated into pu via git@aeb4f90. |
This patch series was integrated into pu via git@8e305d8. |
This patch series was integrated into pu via git@487c771. |
This patch series was integrated into pu via git@cdaf311. |
This patch series was integrated into pu via git@0e74942. |
This patch series was integrated into pu via git@dec0f53. |
This patch series was integrated into pu via git@c4e9a90. |
This patch series was integrated into pu via git@0578cc6. |
This patch series was integrated into pu via git@d5af61a. |
This patch series was integrated into pu via git@28bc238. |
This patch series was integrated into pu via git@dfecfcb. |
This actually made it into v2.23.0 as b2f5171... |
Before this patch, there is inconsistency between the status
messages with hints and the ones without hints: there is an
empty line between the title and the file list if hints are
presented, but there isn't one if there are no hints.
This patch remove the inconsistency by removing the empty
lines even if hints are presented.