windows: avoid illegal filenames during a build #216
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `+` is not a valid part of a filename with Windows file systems (it is reserved because the `+` operator meant file concatenation back in the DOS days). When building in Git for Windows' SDK, the `make.exe` that interprets our `Makefile` is an MSYS2 program, which uses the MSYS2/Cygwin trick of mapping such illegal characters into the private Unicode page, so as long as you use programs that are aware of this trick (all MSYS2/Cygwin programs are, however e.g. `git.exe` is not) things are all dandy. Let's just not use the `+` character. Signed-off-by: Johannes Schindelin <[email protected]>
|
/submit |
|
Submitted as [email protected] |
![gitgitgadget[bot]](https://avatars.githubusercontent.com/in/12836?s=60&v=4){kind=small}
|
Looks like this change has to be reverted out of Git for Windows, and this PR needs to be closed without being merged. Let's give Junio a bit of time to ultimately make up his mind about the aesthetic concerns I have about the current code. |
dscho
added a commit
to git-for-windows/git
that referenced
this pull request
Jul 29, 2019
The problem this patch tried to solve is that `+` is not a valid part of a file name on FAT file systems, so it won't work in general. In practice, it still will work, at least for building Git for Windows, because the MSYS2 runtime uses a trick inherited from Cygwin to handle file names that would be illegal: the characters are simply mapped into a private Unicode page. This patch was soundly rejected on the Git mailing list (see gitgitgadget#216 for details), in particular after this developer figured out that `+` is actually a valid file name character on NTFS. So let's drop it from Git for Windows' patch thicket. Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
+is not allowed on NTFS filesystems. Even if the MSYS2make/bashwe use to build Git for Windows can work around it, it is not necessary.