Skip to content

Use user supplied origin name for extension.partialcone instead of #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

delphij
Copy link

@delphij delphij commented May 23, 2019

hardcoded value.

@gitgitgadget
Copy link

gitgitgadget bot commented May 23, 2019

Welcome to GitGitGadget

Hi @delphij, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that this Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

  • the lines should not exceed 76 columns,
  • the first line should be like a header and typically start with a prefix like "tests:" or "commit:", and
  • the commit messages' body should be describing the "why?" of the change.
  • Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a PR comment of the form /allow <username>.

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions.

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox ("raw") file corresponding to the mail you want to reply to from the Git mailing list. If you use GMail, you can upload that raw mbox file via:

curl -g --user "<EMailAddress>:<Password>" --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

@gitgitgadget
Copy link

gitgitgadget bot commented May 23, 2019

Error: User delphij is not permitted to use GitGitGadget

@dscho
Copy link
Member

dscho commented May 24, 2019

/allow delphij

@gitgitgadget
Copy link

gitgitgadget bot commented May 24, 2019

User delphij is now allowed to use GitGitGadget.

@dscho
Copy link
Member

dscho commented May 24, 2019

Welcome, @delphij! I just added you to the list of users allowed to use GitGitGadget.

Please note that the Pipeline failed in t7519 due to a known bug that I hope to have addressed in #223. I re-triggered the failing job and it will probably pass now.

On another note: please re-review the commit message. It is quite terse compared to Git's preferred style. See e.g. f3a3a02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants