bundle verify: improve the user experience when called without a .git/ directory #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/submit |
|
Submitted as [email protected] |
![gitgitgadget[bot]](https://avatars.githubusercontent.com/in/12836?s=60&v=4){kind=small}
dscho
force-pushed
the
fix-bundle-verify-segfault
branch
from
f0545e8 to
8467593
Compare
|
/submit |
|
Submitted as [email protected] |
Bundles really are thin packs (i.e. in general, they require an object database to reconstruct deltified objects), with very little sugar on top. So we really need a repository (or more appropriately, an object database) to work with, when asked to verify a bundle. Let's error out with a useful error message if `git bundle verify` is called without such an object database to work with. Reported by Konstantin Ryabitsev. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
fix-bundle-verify-segfault
branch
from
8467593 to
b471c5c
Compare
|
/submit |
|
Submitted as [email protected] |
|
This has been accepted as git/git@3bbbe46 (v1, that is, v2 and v3 did not make it to the list, and I failed to notice this.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
git bundle verify <bundle>command really needs access to a.git/directory. But it did not make sure, instead erroring out with aBUG(), making for a terrible user experience.This patch fixes that.
Changes since v2:
bundle.ctobuiltin/bundle.c.Changes since v1:
Cc: Konstantin Ryabitsev [email protected], SZEDER Gábor [email protected], brian m. carlson [email protected], Jeff King [email protected]