-
Notifications
You must be signed in to change notification settings - Fork 140
Make rebase.reschedulefailedexec less overzealous #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rebase.reschedulefailedexec less overzealous #253
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run "CI for GitGitGadget's Git fork" |
No pipelines are associated with this pull request. |
It would be cumbersome to type out that option all the time, so let's offer the convenience of a config setting: rebase.rescheduleFailedExec. Besides, this opens the door to changing the default in a future version of Git: it does make some sense to reschedule failed `exec` commands by default (and if we could go back in time when the `exec` command was invented, we probably would change that default right from the start). Signed-off-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
/submit |
Submitted as [email protected] |
This branch is now known as |
This patch series was integrated into pu via git@9f851e5. |
This patch series was integrated into pu via git@6e4d64a. |
This patch series was integrated into pu via git@de4605e. |
adc54cb
to
beaeb24
Compare
The `exec` command is specific to the interactive backend, therefore it does not make sense for non-interactive rebases to heed that config setting. We still want to error out if a non-interactive rebase is started with `--reschedule-failed-exec`, of course. Reported by Vas Sudanagunta via: git@969de3ff0e0#commitcomment-33257187 Signed-off-by: Johannes Schindelin <[email protected]>
This patch series was integrated into pu via git@d6d7f71. |
/submit |
Submitted as [email protected] |
This patch series was integrated into pu via git@70e16b5. |
This patch series was integrated into pu via git@76931b3. |
This patch series was integrated into pu via git@baf4495. |
This patch series was integrated into pu via git@f82cffc. |
This patch series was integrated into pu via git@b19e6ae. |
This patch series was integrated into pu via git@6de25cc. |
This patch series was integrated into next via git@a13c744. |
This patch series was integrated into pu via git@64096fb. |
This patch series was integrated into next via git@64096fb. |
This patch series was integrated into master via git@64096fb. |
Closed via 64096fb. |
This config setting is pretty useful, but it unfortunately stops all non-interactive rebases with a bogus error message. This patch fixes that.
Reported via a commit comment on GitHub.
Changes since v1:
--exec
, so that users do not have to know that--exec
implies the interactive backend.Cc: Vas Sudanagunta [email protected]