git-gui (Windows): use git-bash.exe if it is available #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git for Windows 2.x ships with an executable that starts the Git Bash with all the environment variables and what not properly set up. It is also adjusted according to the Terminal emulator option chosen when installing Git for Windows (while `bash.exe --login -i` would always launch with Windows' default console). So let's use that executable (usually C:\Program Files\Git\git-bash.exe) instead of `bash.exe --login -i` if its presence was detected. This fixes git-for-windows#490 Signed-off-by: Thomas Kläger <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
|
/submit |
|
Submitted as [email protected] |
![gitgitgadget[bot]](https://avatars.githubusercontent.com/in/12836?s=60&v=4){kind=small}
| @@ -2700,10 +2700,18 @@ if {![is_bare]} { | |||
| } | |||
There was a problem hiding this comment.
On the Git mailing list, Pratyush Yadav wrote (reply to this):
On 26/09/19 10:46AM, Thomas Klaeger via GitGitGadget wrote:
> From: Thomas Klaeger <[email protected]>
>
> Git for Windows 2.x ships with an executable that starts the Git Bash
> with all the environment variables and what not properly set up. It is
> also adjusted according to the Terminal emulator option chosen when
> installing Git for Windows (while `bash.exe --login -i` would always
> launch with Windows' default console).
>
> So let's use that executable (usually C:\Program Files\Git\git-bash.exe)
> instead of `bash.exe --login -i` if its presence was detected.
>
> This fixes https://github.com/git-for-windows/git/issues/490
>
> Signed-off-by: Thomas Kl�ger <[email protected]>
While applying the patch, my patch check script complained that the
author did not sign off.
Well, they did... but with a slightly different name (Kl�ger vs
Klaeger) and a completely different email address.
I'm not sure if I can do something about it, just thought it was
something worth mentioning.
--
Regards,
Pratyush Yadav
|
This finally made it upstream as 6a72d44 (git-gui (Windows): use git-bash.exe if it is available, 2019-09-26) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and yet another patch that is carried in Git for Windows for quite a long time.
This commit was contributed as https://github.com/patthoyts/git/gui/pull/6 which was ignored for almost three years, and then as prati0100/git-gui#2 which was rejected in favor of a mailing list-centric workflow.
The patch is based on Git GUI's
masterbranch at https://github.com/prati0100/git-gui/.Cc: Pratyush Yadav [email protected]