Skip to content

fetch --multiple: respect --jobs=<n> #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fetch --multiple: respect --jobs=<n> #369

wants to merge 1 commit into from

Conversation

dscho
Copy link
Member

@dscho dscho commented Sep 30, 2019 •
edited
Loading

I saw with sadness that pd/fetch-jobs went nowhere, and read in the most recent What's Cooking mail that it was even dropped.

This is my attempt to resurrect the idea (although without the overhead of trying to support a first-class UI to control submodule and multiple-remote fetches independently, of which I was a rather outspoken opponent).

To make things a bit safer, this patch uses the --end-of-options marker, and is therefore based on top of jk/eoo.

Changes since v1:

  • The regression test now passes even under GETTEXT_POISON.
  • The needles used in the regression test are now more indicative of the code producing them.

@dscho
Copy link
Member Author

dscho commented Oct 1, 2019

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 1, 2019

Submitted as [email protected]

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 2, 2019

This branch is now known as js/fetch-jobs.

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 2, 2019

This patch series was integrated into pu via git@6f82b48.

@gitgitgadget gitgitgadget bot added the pu label Oct 2, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented Oct 3, 2019

This patch series was integrated into pu via git@da9a9fa.

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 4, 2019

This patch series was integrated into pu via git@0ca95d9.

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 4, 2019

This patch series was integrated into pu via git@bfcc8df.

@dscho
fetch: let --jobs=<n> parallelize --multiple, too
93a155a 
So far, `--jobs=<n>` only parallelizes submodule fetches/clones, not
`--multiple` fetches, which is unintuitive, given that the option's name
does not say anything about submodules in particular.

Let's change that. With this patch, also fetches from multiple remotes
are parallelized.

For backwards-compatibility (and to prepare for a use case where
submodule and multiple-remote fetches may need different parallelization
limits), the config setting `submodule.fetchJobs` still only controls
the submodule part of `git fetch`, while the newly-introduced setting
`fetch.parallel` controls both (but can be overridden for submodules
with `submodule.fetchJobs`).

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho
Copy link
Member Author

dscho commented Oct 5, 2019

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 5, 2019

Submitted as [email protected]

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 6, 2019

This patch series was integrated into pu via git@a9467ae.

@weekly-digest weekly-digest bot mentioned this pull request Oct 6, 2019
Closed
@gitgitgadget
Copy link

gitgitgadget bot commented Oct 7, 2019

This patch series was integrated into pu via git@5640973.

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 7, 2019

This patch series was integrated into next via git@e798bac.

@gitgitgadget gitgitgadget bot added the next label Oct 7, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented Oct 8, 2019

This patch series was integrated into pu via git@8e67557.

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 9, 2019

This patch series was integrated into pu via git@ba83ce5.

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 9, 2019

This patch series was integrated into pu via git@407c7eb.

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 11, 2019

This patch series was integrated into pu via git@9e571f6.

@weekly-digest weekly-digest bot mentioned this pull request Oct 13, 2019
Closed
@gitgitgadget
Copy link

gitgitgadget bot commented Oct 15, 2019

This patch series was integrated into pu via git@d96e31e.

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 15, 2019

This patch series was integrated into next via git@d96e31e.

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 15, 2019

This patch series was integrated into master via git@d96e31e.

@gitgitgadget gitgitgadget bot added the master label Oct 15, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented Oct 15, 2019

Closed via d96e31e.

@gitgitgadget gitgitgadget bot closed this Oct 15, 2019
@dscho dscho deleted the fetch-jobs branch October 15, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitgitgadget gitgitgadget[bot] gitgitgadget[bot] left review comments

Assignees
No one assigned
Labels
master next pu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dscho