Avoid segmentation fault in git range-diff when diff.noprefix=true
#373
Conversation
|
/submit |
|
Submitted as [email protected] |
![gitgitgadget[bot]](https://avatars.githubusercontent.com/in/12836?s=60&v=4){kind=small}
When parsing the diffs, `range-diff` expects to see the prefixes `a/` and `b/` in the diff headers. These prefixes can be forced off via the config setting `diff.noprefix=true`. As `range-diff` is not prepared for that situation, this will cause a segmentation fault. Let's avoid that by passing the `--no-prefix` option to the `git log` process that generates the diffs that `range-diff` wants to parse. And of course expect the output to have no prefixes, then. Reported-by: Michal Suchánek <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
range-diff-requires-diff-prefix
branch
from
1f84f92 to
9993a60
Compare
|
/submit |
|
Submitted as [email protected] |
|
This branch is now known as |
|
This patch series was integrated into pu via git@0a9ea6d. |
|
This patch series was integrated into pu via git@9f8f210. |
|
This patch series was integrated into pu via git@728ebf4. |
|
This patch series was integrated into next via git@56cf767. |
|
This patch series was integrated into pu via git@650ab5e. |
|
This patch series was integrated into pu via git@fadd080. |
|
This patch series was integrated into pu via git@ba49118. |
|
This patch series was integrated into pu via git@0a9ce69. |
|
This patch series was integrated into pu via git@728f5c6. |
|
This patch series was integrated into pu via git@159cdab. |
|
This patch series was integrated into next via git@159cdab. |
|
This patch series was integrated into master via git@159cdab. |
|
Closed via 159cdab. |
This PR was inspired by this bug report: https://public-inbox.org/git/[email protected]/T/#me576615d7a151cf2ed46186c482fbd88f9959914
Changes since v1:
Cc: Eric Sunshine [email protected], Michal Suchánek [email protected]