[guitool] feature to specify keyboard shortcuts for custom tools #376

harish2704 · 2019-10-05T12:16:37Z

This feature will add following introduce following optional
configuration key into gitconfig

guitool..gitgui-shortcut

Specifies a keyboard shortcut for the custom tool in the git-gui application. The value must be a valid string ( without "<" , ">" wrapper ) understood by the TCL/TK 's bind command. See https://www.tcl.tk/man/tcl8.4/TkCmd/bind.htm for more details about the supported values. Avoid creating shortcuts that conflict with existing built-in `git gui` shortcuts.

Example:

[guitool "Terminal"]
	cmd = gnome-terminal -e zsh
	noconsole = yes
	gitgui-shortcut = "Control-y"
[guitool "Sync"]
	cmd = "git pull; git push"
	gitgui-shortcut = "Alt-s"

gitgitgadget · 2019-10-05T12:17:26Z

Welcome to GitGitGadget

Hi @harish2704, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that this Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

the lines should not exceed 76 columns,
the first line should be like a header and typically start with a prefix like "tests:" or "commit:", and
the commit messages' body should be describing the "why?" of the change.
Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a PR comment of the form /allow <username>.

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions.

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox ("raw") file corresponding to the mail you want to reply to from the Git mailing list. If you use GMail, you can upload that raw mbox file via:

curl -g --user "<EMailAddress>:<Password>" --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

dscho · 2019-10-05T20:09:30Z

@harish2704 I allowed myself to edit the PR description that did not show up well (and that would have rendered totally crappily in the cover letter) and that still included the warning that you should not open a PR at https://github.com/git/git.

Hope you don't mind!

dscho · 2019-10-05T20:09:35Z

/allow

gitgitgadget · 2019-10-05T20:10:28Z

User harish2704 is now allowed to use GitGitGadget.

dscho · 2019-10-05T20:13:54Z

lib/tools.tcl

@@ -61,9 +61,18 @@ proc tools_populate_one {fullname} {
 		}
 	}

-	tools_create_item $parent command \
+	if {[info exists repo_config(guitool.$fullname.gitgui-shortcut)]} {
+		set gitgui_shortcut $repo_config(guitool.$fullname.gitgui-shortcut)


Does the variable really have to have the prefix gitgui_? This is Git GUI's source code after all, so it is kinda redundant?

That make sense.
So, What should I do now? Can I simply edit it in a new commit ? ( it know that it will work for PR based work flow, but I don't how it will work for mailing list based work flow )

In Git (and as a consequence, Git GUI), introducing a bug in one patch, only to fix it immediately in a following patch, is highly frowned upon.

Therefore I would strongly suggest to amend and force-push.

dscho · 2019-10-06T09:07:10Z

BTW as this is a continuation of git#220, how about closing that PR?

harish2704 · 2019-10-06T09:06:29Z

lib/tools.tcl

@@ -61,9 +61,18 @@ proc tools_populate_one {fullname} {
 		}
 	}

-	tools_create_item $parent command \
+	if {[info exists repo_config(guitool.$fullname.gitgui-shortcut)]} {
+		set accel_key $repo_config(guitool.$fullname.gitgui-shortcut)


@dscho : I fixed the variable naming you suggested.

harish2704 · 2019-10-06T09:12:30Z

@dscho : Done git#220 (comment)

dscho · 2019-10-06T20:23:56Z

/allow prati0100

gitgitgadget · 2019-10-06T20:25:05Z

User prati0100 is now allowed to use GitGitGadget.

dscho · 2019-10-06T20:27:04Z

User prati0100 is now allowed to use GitGitGadget.

@prati0100 there you go.

prati0100 · 2019-10-06T20:46:44Z

Thanks @dscho

This feature will add following introduce following optional configuration key into gitconfig guitool.<name>.gitgui-shortcut Specifies a keyboard shortcut for the custom tool in the git-gui application. The value must be a valid string ( without "<" , ">" wrapper ) understood by the TCL/TK 's bind command.See https://www.tcl.tk/man/tcl8.4/TkCmd/bind.htm for more details about the supported values. Avoid creating shortcuts that conflict with existing built-in `git gui` shortcuts. Example: [guitool "Terminal"] cmd = gnome-terminal -e zsh noconsole = yes gitgui-shortcut = "Control-y" [guitool "Sync"] cmd = "git pull; git push" gitgui-shortcut = "Alt-s" Signed-off-by: Harish.K <[email protected]>

dscho reviewed Oct 5, 2019

View reviewed changes

weekly-digest bot mentioned this pull request Oct 6, 2019

Weekly Digest (29 September, 2019 - 6 October, 2019) #377

Closed

harish2704 force-pushed the gitgui-master branch from 42565be to 91d864a Compare October 6, 2019 09:04

harish2704 commented Oct 6, 2019

View reviewed changes

harish2704 mentioned this pull request Oct 6, 2019

Feature: custom guitool commands can now have custom keyboard shortcuts git/git#220

Closed

harish2704 force-pushed the gitgui-master branch from 91d864a to cb81cae Compare October 8, 2019 19:11

weekly-digest bot mentioned this pull request Oct 13, 2019

Weekly Digest (6 October, 2019 - 13 October, 2019) #393

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[guitool] feature to specify keyboard shortcuts for custom tools #376

[guitool] feature to specify keyboard shortcuts for custom tools #376

harish2704 commented Oct 5, 2019 •

edited by dscho

Loading

gitgitgadget bot commented Oct 5, 2019

dscho commented Oct 5, 2019

dscho commented Oct 5, 2019

gitgitgadget bot commented Oct 5, 2019

dscho Oct 5, 2019

harish2704 Oct 5, 2019

dscho Oct 6, 2019

dscho commented Oct 6, 2019

harish2704 Oct 6, 2019

harish2704 commented Oct 6, 2019

dscho commented Oct 6, 2019

gitgitgadget bot commented Oct 6, 2019

dscho commented Oct 6, 2019

prati0100 commented Oct 6, 2019

[guitool] feature to specify keyboard shortcuts for custom tools #376

Are you sure you want to change the base?

[guitool] feature to specify keyboard shortcuts for custom tools #376

Conversation

harish2704 commented Oct 5, 2019 • edited by dscho Loading

gitgitgadget bot commented Oct 5, 2019

Welcome to GitGitGadget

Contributing the patches

dscho commented Oct 5, 2019

dscho commented Oct 5, 2019

gitgitgadget bot commented Oct 5, 2019

dscho Oct 5, 2019

Choose a reason for hiding this comment

harish2704 Oct 5, 2019

Choose a reason for hiding this comment

dscho Oct 6, 2019

Choose a reason for hiding this comment

dscho commented Oct 6, 2019

harish2704 Oct 6, 2019

Choose a reason for hiding this comment

harish2704 commented Oct 6, 2019

dscho commented Oct 6, 2019

gitgitgadget bot commented Oct 6, 2019

dscho commented Oct 6, 2019

prati0100 commented Oct 6, 2019

harish2704 commented Oct 5, 2019 •

edited by dscho

Loading