t1308-config-set: fix a test that has a typo #387
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change test 'find value_list for a key from a configset' to redirect the result to 'expect' instead of 'except' which was a typo. With this change, the test case actually fails because it uses `configset_get_value`. Clearly, this was intended to be `configset_get_value_multi` since the test expects a list of values instead of a single value, so let's fix that, too. Originally contributed as git#451. Signed-off-by: Tanay Abhra <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
|
/submit |
|
Submitted as [email protected] |
![gitgitgadget[bot]](https://avatars.githubusercontent.com/in/12836?s=60&v=4){kind=small}
|
This branch is now known as |
|
This patch series was integrated into pu via git@760c9a7. |
|
This patch series was integrated into pu via git@f24c35c. |
|
This patch series was integrated into pu via git@f9a6540. |
|
This patch series was integrated into next via git@0228b44. |
|
This patch series was integrated into pu via git@7db8972. |
|
This patch series was integrated into pu via git@cdc196d. |
|
This patch series was integrated into pu via git@9b83a94. |
|
This patch series was integrated into next via git@9b83a94. |
|
This patch series was integrated into master via git@9b83a94. |
|
Closed via 9b83a94. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently trying to whittle down the number of open PRs at https://github.com/git/git, and this is one of the patches I deem valuable enough (and complete enough) to put through to the Git mailing list even when the original contributor has gone silent.