gitk: Preserve window dimensions on exit when not using ttk themes

[echuber2]

This fix is intended to let gitk preserve the window pane dimensions regardless of whether ttk is enabled or not. I'm not an expert on Tcl/Tk but as far as I can tell, this edit works and doesn't cause problems. Please double-check what I did.

Cc: Paul Mackerras [email protected]

[gitgitgadget]

Welcome to GitGitGadget

Hi @echuber2, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that this Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

• the lines should not exceed 76 columns,
• the first line should be like a header and typically start with a prefix like "tests:" or "commit:", and
• the commit messages' body should be describing the "why?" of the change.
• Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a PR comment of the form /allow <username>.

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions.

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox ("raw") file corresponding to the mail you want to reply to from the Git mailing list. If you use GMail, you can upload that raw mbox file via:

curl -g --user "<EMailAddress>:<Password>" --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

[echuber2]

I'm not sure why these CI checks are failing (currently).

[dscho]

I'm not sure why these CI checks are failing (currently).

Some of them are flaky. I restarted the CI, and now all is green.

Please note that you will want to Cc: the gitk maintainer, Paul Mackerras ([email protected]), explicitly. You can do so by adding a footer to your PR description: Cc: Paul Mackerras <[email protected]>.

[dscho]

/allow

[dscho]

(Sorry for not noticing earlier that you need to get into that list of permitted GitGitGadget users...)

[gitgitgadget]

User echuber2 is now allowed to use GitGitGadget.

WARNING: echuber2 has no public email address set on GitHub

[echuber2]

Please note that you will want to Cc: the gitk maintainer, Paul Mackerras ([email protected]), explicitly. You can do so by adding a footer to your PR description: Cc: Paul Mackerras <[email protected]>.

Thanks. Have I done so properly now?

[dscho]

Have I done so properly now?

I would remove the Signed-off-by: line (it really is only needed in commit messages, not in the cover letter), and I would try not to repeat in the cover letter what the patch text is already saying...

(Background: there has been talk on the Git mailing list that some people prefer 1-patch "patch series" not to have a cover letter at all, but GitGitGadget does not support that yet.)

[dscho]

Have I done so properly now?

I would remove the Signed-off-by: line (it really is only needed in commit messages, not in the cover letter), and I would try not to repeat in the cover letter what the patch text is already saying...

I should have clarified: yes, the addition of the Cc: line should work.

[echuber2]

I've edited my top comment in this thread, assuming that's what becomes the "cover letter". Please let me know if there's anything else I need to do.

[dscho]

I've edited my top comment in this thread

Looks good to me!

[echuber2]

All right, thanks. I'll try sending this then.

[echuber2]

/submit

[gitgitgadget]

Submitted as [email protected]

WARNING: echuber2 has no public email address set on GitHub

[gitgitgadget]

On the Git mailing list, Paul Mackerras wrote (reply to this):

On Tue, Oct 15, 2019 at 12:13:16AM +0000, Eric Huber via GitGitGadget wrote:
> From: Eric Huber <[email protected]>
> 
> Bug was: gitk would overwrite the botwidth setting in .gitk with
> a nonsense value when not using tk themes. I'm not sure if this
> is the right fix or not but it seems to work. Moving the affected
> line within the conditional results in the expected behavior.
> 
> Signed-off-by: Eric Huber <[email protected]>

Thanks, patch applied.

Paul.