githooks.txt: use correct "reference-transaction" hook name

[0xd219b]

CC: Patrick Steinhardt [email protected], Jiang Xin [email protected]

[0xd219b]

/submit

[gitgitgadget]

Submitted as [email protected]

[gitgitgadget]

On the Git mailing list, Patrick Steinhardt wrote (reply to this):

--aVD9QWMuhilNxW9f
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Bojun,

On Fri, Jul 24, 2020 at 01:57:57PM +0000, starlord via GitGitGadget wrote:
> From: Bojun Chen <[email protected]>
>=20
> The "reference transaction" hook was introduced in commit 6754159767
> (refs: implement reference transaction hook, 2020-06-19). The name of
> the hook is declared as "reference-transaction" in "refs.c" and
> testcases, but the name declared in "githooks.txt" is different.
>=20
> Signed-off-by: Bojun Chen <[email protected]>

Indeed, thanks for catching this!

Reviewed-by: Patrick Steinhardt <[email protected]>

Patrick

> ---
>     githooks.txt: use correct "reference-transaction" hook name
>=20
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-681%2FB=
erger7%2Fmaster-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-681/Berger=
7/master-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/681
>=20
>  Documentation/githooks.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
> index 642471109f..31b601e4bc 100644
> --- a/Documentation/githooks.txt
> +++ b/Documentation/githooks.txt
> @@ -404,8 +404,8 @@ Both standard output and standard error output are fo=
rwarded to
>  `git send-pack` on the other end, so you can simply `echo` messages
>  for the user.
> =20
> -ref-transaction
> -~~~~~~~~~~~~~~~
> +reference-transaction
> +~~~~~~~~~~~~~~~~~~~~~
> =20
>  This hook is invoked by any Git command that performs reference
>  updates. It executes whenever a reference transaction is prepared,
>=20
> base-commit: 3d20111cbd42c9ef3116bb629838bcbfea508cda
> --=20
> gitgitgadget

--aVD9QWMuhilNxW9f
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl8a7oMACgkQVbJhu7ck
PpQF5g//Tn5k33U797quFVB1yJoHtfiJtJbdPR2YYALcxtFQElM4YrdFCabKzPZ6
8r1yTO4KBMwR1hgT1ErYnbAc84vNgdu4h/cyNXUsyEC0VZo+iW4ZnsUJle2fnh0y
FevW7j9zGfw/MIIE5I/NBdJIL5nrEpdHuC5hvIfyInSkU67ltEy/M2JH/VJnXoSX
e9r4DQbFUQZNLAhzSyth5ApYo8LeY1yIjAhSwORHCAMtCANitmhSLIqIONCfsOmk
CHha7wqEPe7Dsmb0CetS3NqgBG3VemXukqroAaQIkt/u4/jmeKr7lrVBos6A1b/u
4OfFJsmj8XKxwNcmOB+DIciU+d3eiF+lvYC6m3hYfwO9QagDmv7BAA7PajubinoM
ZnSrjLk8MlcAgSnluhIwDwOtOuwzbTNTGLO7HWipHXFKVLymyhur3+MnKwsl6SxT
p8813FGbAOE2oDh+Z1Grs8w5UGn4vAgN6oIHeNUALKhN8m6KKs9TPa1WDkuI6LC+
lj8czEUnuAEzh/TiM2jmsPAgUws4QFH352neUcZIlKwtw9dOJYLzurV8Y1wUGnBn
YgA571jMIINZx1Tr2os6S6dRaKJnrRvaqaCOK8Olfg6ag1ak2LzDiWqqVvUu7XTo
tLpQ2EMHLqPlLCfYYeyWiwYpk2/6HN757XU4Lki8MCkIqZrQkco=
=JdZ0
-----END PGP SIGNATURE-----

--aVD9QWMuhilNxW9f--

[gitgitgadget]

On the Git mailing list, Junio C Hamano wrote (reply to this):

Patrick Steinhardt <[email protected]> writes:

> Hi Bojun,
>
> On Fri, Jul 24, 2020 at 01:57:57PM +0000, starlord via GitGitGadget wrote:
>> From: Bojun Chen <[email protected]>
>> 
>> The "reference transaction" hook was introduced in commit 6754159767
>> (refs: implement reference transaction hook, 2020-06-19). The name of
>> the hook is declared as "reference-transaction" in "refs.c" and
>> testcases, but the name declared in "githooks.txt" is different.
>> 
>> Signed-off-by: Bojun Chen <[email protected]>
>
> Indeed, thanks for catching this!
>
> Reviewed-by: Patrick Steinhardt <[email protected]>

Thanks.

[gitgitgadget]

This branch is now known as ps/ref-transaction-hook.

[gitgitgadget]

This patch series was integrated into seen via git@8d690a9.

[gitgitgadget]

This patch series was integrated into next via git@4e02568.

[gitgitgadget]

This patch series was integrated into seen via git@418cca9.

[gitgitgadget]

This patch series was integrated into next via git@bb35597.

[gitgitgadget]

This patch series was integrated into master via git@418cca9.

[gitgitgadget]

Closed via 418cca9.