Improve the example that illustrates git-notes path names #692

noamraph · 2020-08-03T11:13:35Z

docs: improve the example that illustrates git-notes path names

Make it clear that the filename has only the rest of the object ID,
not the entirety of it.

Changes since v1:

Improved the commit message, according to comments by Taylor Blau.
Changed the parts to random hex, so the '...' won't be confusing, according to suggestion by Junio C Hamano.

gitgitgadget · 2020-08-03T11:14:25Z

Welcome to GitGitGadget

Hi @noamraph, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that your Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

the lines should not exceed 76 columns,
the first line should be like a header and typically start with a prefix like "tests:" or "commit:", and
the commit messages' body should be describing the "why?" of the change.
Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

Search: is:pr is:open "/allow"

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the FreeNode IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

If you want to see what email(s) would be sent for a /submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail).

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the (raw) link), then import it into your mail program. If you use GMail, you can do this via:

curl -g --user "<EMailAddress>:<Password>" \
    --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):

Changes since v1:
- Fixed a typo in the commit message (found by ...)
- Added a code comment to ... as suggested by ...
...

To send a new iteration, just add another PR comment with the contents: /submit.

Need help?

New contributors who want advice are encouraged to join [email protected], where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Freenode. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

gitgitgadget · 2020-08-03T11:14:25Z

There is an issue in commit 9d656a7:
Commit not signed off

gitgitgadget · 2020-08-03T11:23:42Z

There is an issue in commit b7824ec:
Prefixed commit message must be in lower case: docs: Improve the example that illustrates git-notes path names

noamraph · 2020-08-03T11:35:46Z

/preview

gitgitgadget · 2020-08-03T11:36:22Z

Error: User noamraph is not permitted to use GitGitGadget

harry-hov · 2020-08-03T12:42:50Z

/allow

gitgitgadget · 2020-08-03T12:43:44Z

User noamraph is now allowed to use GitGitGadget.

noamraph · 2020-08-03T14:32:08Z

/preview

gitgitgadget · 2020-08-03T14:33:02Z

Preview email sent as [email protected]

noamraph · 2020-08-03T14:42:51Z

/submit

gitgitgadget · 2020-08-03T14:43:54Z

Submitted as [email protected]

gitgitgadget · 2020-08-03T15:49:55Z

On the Git mailing list, Taylor Blau wrote (reply to this):

On Mon, Aug 03, 2020 at 02:43:36PM +0000, Noam Yorav-Raphael via GitGitGadget wrote:
> From: Noam Yorav-Raphael <[email protected]>
>
> The existing git-notes doc says:
>
> > Permitted pathnames have the form ab/cd/ef/…/abcdef…: a sequence of
> > directory names of two hexadecimal digits each followed by a filename
> > with the rest of the object ID.

This part of the commit message is unnecessary, since it can easily be
read off from the diff.

>
> Even though the text says that the filename has the rest of the object ID,
> I felt the need to check this, since the example gives the impression that
> the filename is the entire object ID (a schema which is quite prevalent).
>
> The new example makes it clear that the filename has only the rest of the
> object ID, and not the entire object ID.

Please use the imperative mood here. Instead of the above, consider:

  Make it clear that the filename has only the rest of the object ID,
  not the entirety of it.

> Signed-off-by: Noam Yorav-Raphael <[email protected]>
> ---
>     Improve the example that illustrates git-notes path names
>
>     The existing git-notes doc says:
>
>     > Permitted pathnames have the form ab/cd/ef/…/abcdef…: a sequence of
>     > directory names of two hexadecimal digits each followed by a filename
>     > with the rest of the object ID.
>
>     Even though the text says that the filename has the rest of the object
>     ID, I felt the need to check this, since the example gives the
>     impression that the filename is the entire object ID (a schema which is
>     quite prevalent).
>
>     The new example makes it clear that the filename has only the rest of
>     the object ID, and not the entire object ID.
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-692%2Fnoamraph%2Fclearer-notes-path-doc-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-692/noamraph/clearer-notes-path-doc-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/692
>
>  Documentation/git-notes.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt
> index ced2e8280e..9fc1979531 100644
> --- a/Documentation/git-notes.txt
> +++ b/Documentation/git-notes.txt
> @@ -223,7 +223,7 @@ are taken from notes refs.  A notes ref is usually a branch which
>  contains "files" whose paths are the object names for the objects
>  they describe, with some directory separators included for performance
>  reasons footnote:[Permitted pathnames have the form
> -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory
> +'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory

I had to read this twice to figure out why the first 'ab' changed to
'12'. It appears that this is to avoid having to use 'gh...' in the
last directory, since 'g', 'h' and so on aren't hexadecimal digits.

Makes sense.

>  names of two hexadecimal digits each followed by a filename with the
>  rest of the object ID.].
>
>
> base-commit: 85b4e0a6dc8407de6f69808d9ee6debdf167ced3
> --
> gitgitgadget

The patch looks fine, but the commit message needs some tweaking.
Thanks.

Thanks,
Taylor

noamraph · 2020-08-03T16:17:10Z

/preview

gitgitgadget · 2020-08-03T16:17:58Z

Preview email sent as [email protected]

noamraph · 2020-08-03T16:20:31Z

/submit

gitgitgadget · 2020-08-03T16:21:34Z

Submitted as [email protected]

gitgitgadget · 2020-08-03T16:34:57Z

On the Git mailing list, Taylor Blau wrote (reply to this):

Hi Noam,

On Mon, Aug 03, 2020 at 04:21:16PM +0000, Noam Yorav-Raphael via GitGitGadget wrote:
> From: Noam Yorav-Raphael <[email protected]>
>
> Make it clear that the filename has only the rest of the object ID,
> not the entirety of it.

This looks great, thank you. I left one note below, but I don't think
that you should feel obligated to address it.

> Signed-off-by: Noam Yorav-Raphael <[email protected]>
> ---
>     Improve the example that illustrates git-notes path names
>
>     docs: improve the example that illustrates git-notes path names
>
>     Make it clear that the filename has only the rest of the object ID, not
>     the entirety of it.
>
>     Changed: improved the commit message, according to comments by Taylor
>     Blau.
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-692%2Fnoamraph%2Fclearer-notes-path-doc-v2
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-692/noamraph/clearer-notes-path-doc-v2
> Pull-Request: https://github.com/gitgitgadget/git/pull/692
>
> Range-diff vs v1:
>
>  1:  76a674871a ! 1:  8b3defb657 docs: improve the example that illustrates git-notes path names
>      @@ Metadata
>        ## Commit message ##
>           docs: improve the example that illustrates git-notes path names
>
>      -    The existing git-notes doc says:
>      -
>      -    > Permitted pathnames have the form ab/cd/ef/…/abcdef…: a sequence of
>      -    > directory names of two hexadecimal digits each followed by a filename
>      -    > with the rest of the object ID.
>      -
>      -    Even though the text says that the filename has the rest of the object ID,
>      -    I felt the need to check this, since the example gives the impression that
>      -    the filename is the entire object ID (a schema which is quite prevalent).
>      -
>      -    The new example makes it clear that the filename has only the rest of the
>      -    object ID, and not the entire object ID.
>      +    Make it clear that the filename has only the rest of the object ID,
>      +    not the entirety of it.
>
>           Signed-off-by: Noam Yorav-Raphael <[email protected]>
>
>
>
>  Documentation/git-notes.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt
> index ced2e8280e..9fc1979531 100644
> --- a/Documentation/git-notes.txt
> +++ b/Documentation/git-notes.txt
> @@ -223,7 +223,7 @@ are taken from notes refs.  A notes ref is usually a branch which
>  contains "files" whose paths are the object names for the objects
>  they describe, with some directory separators included for performance
>  reasons footnote:[Permitted pathnames have the form
> -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory
> +'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory

Sorry for not suggesting this earlier, but I think you could just as
easily start this with '01' instead of '12'. I don't think that it
matters, though, the point that you're trying to illustrate is perfectly
clear.

>  names of two hexadecimal digits each followed by a filename with the
>  rest of the object ID.].
>
>
> base-commit: 85b4e0a6dc8407de6f69808d9ee6debdf167ced3
> --
> gitgitgadget

  Reviewed-by: Taylor Blau <[email protected]>

Thanks,
Taylor

gitgitgadget · 2020-08-03T17:08:05Z

On the Git mailing list, Junio C Hamano wrote (reply to this):

Taylor Blau <[email protected]> writes:

>> diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt
>> index ced2e8280e..9fc1979531 100644
>> --- a/Documentation/git-notes.txt
>> +++ b/Documentation/git-notes.txt
>> @@ -223,7 +223,7 @@ are taken from notes refs.  A notes ref is usually a branch which
>>  contains "files" whose paths are the object names for the objects
>>  they describe, with some directory separators included for performance
>>  reasons footnote:[Permitted pathnames have the form
>> -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory
>> +'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory
>
> I had to read this twice to figure out why the first 'ab' changed to
> '12'. It appears that this is to avoid having to use 'gh...' in the
> last directory, since 'g', 'h' and so on aren't hexadecimal digits.

You can wrap-around to '0' after counting up to 'f', no ;-)?

Having '/.../' between '56' and '789' to indicate "there are more
levels possible here" is somewhat misleading with the new example.
We could argue that the original objectname does not have to be
"123456789abc.." but then the whole exercise becomes somewhat
pointless as the objectname could have been 'abcdef...abcdef...'.

Another minor nit: it probably makes it read more natural to start
counting from '0' when writing hexadecimal, if we really want to
use sequence of ascending hexdigits.

Using a seemingly random example 85/b4/.../808d9ee6debdf167ced3
might be less confusing, because ...

>>  names of two hexadecimal digits each followed by a filename with the
>>  rest of the object ID.].

... I think these two lines is pleanty clear than any example, so I
am OK with either the old or the updated example, but I think a
seemingly random example as long as the leaf level does not share
the leading hexdigits as the pathname would work the best.

gitgitgadget · 2020-08-03T17:17:07Z

On the Git mailing list, Taylor Blau wrote (reply to this):

On Mon, Aug 03, 2020 at 10:04:15AM -0700, Junio C Hamano wrote:
> Taylor Blau <[email protected]> writes:
>
> >> diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt
> >> index ced2e8280e..9fc1979531 100644
> >> --- a/Documentation/git-notes.txt
> >> +++ b/Documentation/git-notes.txt
> >> @@ -223,7 +223,7 @@ are taken from notes refs.  A notes ref is usually a branch which
> >>  contains "files" whose paths are the object names for the objects
> >>  they describe, with some directory separators included for performance
> >>  reasons footnote:[Permitted pathnames have the form
> >> -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory
> >> +'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory
> >
> > I had to read this twice to figure out why the first 'ab' changed to
> > '12'. It appears that this is to avoid having to use 'gh...' in the
> > last directory, since 'g', 'h' and so on aren't hexadecimal digits.
>
> You can wrap-around to '0' after counting up to 'f', no ;-)?

;-).

> Having '/.../' between '56' and '789' to indicate "there are more
> levels possible here" is somewhat misleading with the new example.
> We could argue that the original objectname does not have to be
> "123456789abc.." but then the whole exercise becomes somewhat
> pointless as the objectname could have been 'abcdef...abcdef...'.
>
> Another minor nit: it probably makes it read more natural to start
> counting from '0' when writing hexadecimal, if we really want to
> use sequence of ascending hexdigits.
>
> Using a seemingly random example 85/b4/.../808d9ee6debdf167ced3
> might be less confusing, because ...
>
> >>  names of two hexadecimal digits each followed by a filename with the
> >>  rest of the object ID.].
>
> ... I think these two lines is pleanty clear than any example, so I
> am OK with either the old or the updated example, but I think a
> seemingly random example as long as the leaf level does not share
> the leading hexdigits as the pathname would work the best.

I agree with your reasoning (it didn't occur to me as a problem before,
but seeing it spelled out in front of me I could understand how such an
example might be confusing).

Thanks,
Taylor

Make it clear that the filename has only the rest of the object ID, not the entirety of it. Signed-off-by: Noam Yorav-Raphael <[email protected]>

noamraph · 2020-08-03T19:09:23Z

/submit

gitgitgadget · 2020-08-03T19:10:25Z

Submitted as [email protected]

gitgitgadget · 2020-08-03T19:14:35Z

On the Git mailing list, Taylor Blau wrote (reply to this):

On Mon, Aug 03, 2020 at 07:10:15PM +0000, Noam Yorav-Raphael via GitGitGadget wrote:
> From: Noam Yorav-Raphael <[email protected]>
>
> Make it clear that the filename has only the rest of the object ID,
> not the entirety of it.
>
> Signed-off-by: Noam Yorav-Raphael <[email protected]>
> ---
>     Improve the example that illustrates git-notes path names
>
>     docs: improve the example that illustrates git-notes path names
>
>     Make it clear that the filename has only the rest of the object ID, not
>     the entirety of it.
>
>     Changes since v1:
>
>      * Improved the commit message, according to comments by Taylor Blau.
>      * Changed the parts to random hex, so the '...' won't be confusing,
>        according to suggestion by Junio C Hamano.
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-692%2Fnoamraph%2Fclearer-notes-path-doc-v3
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-692/noamraph/clearer-notes-path-doc-v3
> Pull-Request: https://github.com/gitgitgadget/git/pull/692
>
> Range-diff vs v2:
>
>  1:  8b3defb657 ! 1:  e973e321d8 docs: improve the example that illustrates git-notes path names
>      @@ Documentation/git-notes.txt: are taken from notes refs.  A notes ref is usually
>        they describe, with some directory separators included for performance
>        reasons footnote:[Permitted pathnames have the form
>       -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory
>      -+'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory
>      ++'bf'`/`'fe'`/`'30'`/`'...'`/`'680d5a...': a sequence of directory
>        names of two hexadecimal digits each followed by a filename with the
>        rest of the object ID.].
>
>
>
>  Documentation/git-notes.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt
> index ced2e8280e..0a4200674c 100644
> --- a/Documentation/git-notes.txt
> +++ b/Documentation/git-notes.txt
> @@ -223,7 +223,7 @@ are taken from notes refs.  A notes ref is usually a branch which
>  contains "files" whose paths are the object names for the objects
>  they describe, with some directory separators included for performance
>  reasons footnote:[Permitted pathnames have the form
> -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory
> +'bf'`/`'fe'`/`'30'`/`'...'`/`'680d5a...': a sequence of directory
>  names of two hexadecimal digits each followed by a filename with the
>  rest of the object ID.].
>
>
> base-commit: 85b4e0a6dc8407de6f69808d9ee6debdf167ced3
> --
> gitgitgadget

Looks good to me, but Junio should chime in, too.

  Acked-by: Taylor Blau <[email protected]>

Thanks,
Taylor

gitgitgadget · 2020-08-03T19:41:41Z

On the Git mailing list, Junio C Hamano wrote (reply to this):

Taylor Blau <[email protected]> writes:

> On Mon, Aug 03, 2020 at 07:10:15PM +0000, Noam Yorav-Raphael via GitGitGadget wrote:
>> From: Noam Yorav-Raphael <[email protected]>
>>
>> Make it clear that the filename has only the rest of the object ID,
>> not the entirety of it.
>>
>> Signed-off-by: Noam Yorav-Raphael <[email protected]>
>> ---
>>     Improve the example that illustrates git-notes path names
>>
>>     docs: improve the example that illustrates git-notes path names
>>
>>     Make it clear that the filename has only the rest of the object ID, not
>>     the entirety of it.
>>
>>     Changes since v1:
>>
>>      * Improved the commit message, according to comments by Taylor Blau.
>>      * Changed the parts to random hex, so the '...' won't be confusing,
>>        according to suggestion by Junio C Hamano.
>>
>> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-692%2Fnoamraph%2Fclearer-notes-path-doc-v3
>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-692/noamraph/clearer-notes-path-doc-v3
>> Pull-Request: https://github.com/gitgitgadget/git/pull/692
>>
>> Range-diff vs v2:
>>
>>  1:  8b3defb657 ! 1:  e973e321d8 docs: improve the example that illustrates git-notes path names
>>      @@ Documentation/git-notes.txt: are taken from notes refs.  A notes ref is usually
>>        they describe, with some directory separators included for performance
>>        reasons footnote:[Permitted pathnames have the form
>>       -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory
>>      -+'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory
>>      ++'bf'`/`'fe'`/`'30'`/`'...'`/`'680d5a...': a sequence of directory
>>        names of two hexadecimal digits each followed by a filename with the
>>        rest of the object ID.].
>>
>>
>>
>>  Documentation/git-notes.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt
>> index ced2e8280e..0a4200674c 100644
>> --- a/Documentation/git-notes.txt
>> +++ b/Documentation/git-notes.txt
>> @@ -223,7 +223,7 @@ are taken from notes refs.  A notes ref is usually a branch which
>>  contains "files" whose paths are the object names for the objects
>>  they describe, with some directory separators included for performance
>>  reasons footnote:[Permitted pathnames have the form
>> -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory
>> +'bf'`/`'fe'`/`'30'`/`'...'`/`'680d5a...': a sequence of directory
>>  names of two hexadecimal digits each followed by a filename with the
>>  rest of the object ID.].
>>
>>
>> base-commit: 85b4e0a6dc8407de6f69808d9ee6debdf167ced3
>> --
>> gitgitgadget
>
> Looks good to me, but Junio should chime in, too.
>
>   Acked-by: Taylor Blau <[email protected]>

Yeah, thanks, both.

gitgitgadget · 2020-08-03T21:23:06Z

This branch is now known as ny/notes-doc-sample-update.

gitgitgadget · 2020-08-03T21:23:07Z

This patch series was integrated into seen via git@ca9b7c5.

gitgitgadget · 2020-08-04T04:57:51Z

This patch series was integrated into seen via git@fb8169c.

gitgitgadget · 2020-08-04T21:58:38Z

This patch series was integrated into seen via git@bad417c.

gitgitgadget · 2020-08-04T21:58:39Z

This patch series was integrated into next via git@a63dcb2.

gitgitgadget · 2020-08-05T21:09:53Z

This patch series was integrated into seen via git@c1f6eed.

gitgitgadget · 2020-08-05T22:38:28Z

This patch series was integrated into seen via git@366a03e.

gitgitgadget · 2020-08-07T21:48:56Z

This patch series was integrated into seen via git@5bc9d1f.

gitgitgadget · 2020-08-10T18:37:50Z

This patch series was integrated into seen via git@d3e54ed.

gitgitgadget · 2020-08-10T18:37:51Z

This patch series was integrated into next via git@d3e54ed.

gitgitgadget · 2020-08-10T18:37:52Z

This patch series was integrated into master via git@d3e54ed.

gitgitgadget · 2020-08-10T18:37:54Z

Closed via d3e54ed.

noamraph force-pushed the clearer-notes-path-doc branch 2 times, most recently from 9e3d2cf to b7824ec Compare August 3, 2020 11:22

noamraph force-pushed the clearer-notes-path-doc branch from b7824ec to 76a6748 Compare August 3, 2020 11:30

noamraph force-pushed the clearer-notes-path-doc branch from 76a6748 to 8b3defb Compare August 3, 2020 16:11

docs: improve the example that illustrates git-notes path names

e973e32

Make it clear that the filename has only the rest of the object ID, not the entirety of it. Signed-off-by: Noam Yorav-Raphael <[email protected]>

noamraph force-pushed the clearer-notes-path-doc branch from 8b3defb to e973e32 Compare August 3, 2020 19:05

gitgitgadget bot added the seen label Aug 3, 2020

gitgitgadget bot added the next label Aug 4, 2020

weekly-digest bot mentioned this pull request Aug 9, 2020

Weekly Digest (2 August, 2020 - 9 August, 2020) #697

Closed

gitgitgadget bot added the master label Aug 10, 2020

gitgitgadget bot closed this Aug 10, 2020

Improve the example that illustrates git-notes path names #692

Improve the example that illustrates git-notes path names #692

Uh oh!

Conversation

noamraph commented Aug 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Welcome to GitGitGadget

Contributing the patches

Need help?

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

noamraph commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

harry-hov commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

noamraph commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

noamraph commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

noamraph commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

noamraph commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

noamraph commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 3, 2020

Uh oh!

gitgitgadget bot commented Aug 4, 2020

Uh oh!

gitgitgadget bot commented Aug 4, 2020

Uh oh!

gitgitgadget bot commented Aug 4, 2020

Uh oh!

gitgitgadget bot commented Aug 5, 2020

Uh oh!

gitgitgadget bot commented Aug 5, 2020

Uh oh!

gitgitgadget bot commented Aug 7, 2020

Uh oh!

gitgitgadget bot commented Aug 10, 2020

Uh oh!

gitgitgadget bot commented Aug 10, 2020

Uh oh!

gitgitgadget bot commented Aug 10, 2020

Uh oh!

gitgitgadget bot commented Aug 10, 2020

Uh oh!

noamraph commented Aug 3, 2020 •

edited

Loading