Skip to content

mingw: support UNC as file://server/share/repo #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

mingw: support UNC as file://server/share/repo #93

wants to merge 1 commit into from

Conversation

dscho
Copy link
Member

@dscho dscho commented Dec 10, 2018

Windows users might think that the common file:/// protocol also works for network shares. This patch makes it so.

@tboegi @dscho
mingw: support UNC in git clone file://server/share/repo
37957d0 
Extend the parser to accept file://server/share/repo in the way that
Windows users expect it to be parsed who are used to referring to file
shares by UNC paths of the form \\server\share\folder.

[jes: tightened check to avoid handling file://C:/some/path as a UNC
path.]

This closes git-for-windows#1264.

Signed-off-by: Torsten Bögershausen <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho mentioned this pull request Dec 10, 2018
Closed
35 tasks
@dscho dscho added the ready to submit Has commits that have not been submitted yet label Jan 19, 2019
@dscho
Copy link
Member Author

dscho commented Aug 24, 2019

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Aug 24, 2019

Submitted as [email protected]

@dscho dscho removed the ready to submit Has commits that have not been submitted yet label Aug 24, 2019
@weekly-digest weekly-digest bot mentioned this pull request Aug 25, 2019
Closed
@gitgitgadget
Copy link

gitgitgadget bot commented Aug 26, 2019

On the Git mailing list, Junio C Hamano wrote (reply to this):

"Johannes Schindelin via GitGitGadget" <[email protected]>
writes:

> Windows users might think that the common file:/// protocol also works =
for
> network shares. This patch makes it so.

Thanks, both.

>
> Torsten B=C3=B6gershausen (1):
>   mingw: support UNC in git clone file://server/share/repo
>
>  connect.c             |  4 ++++
>  t/t5500-fetch-pack.sh | 13 +++++++++++--
>  2 files changed, 15 insertions(+), 2 deletions(-)
>
>
> base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-93%2F=
dscho%2Ffile-url-to-unc-path-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-93/dscho=
/file-url-to-unc-path-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/93

@gitgitgadget
Copy link

gitgitgadget bot commented Aug 26, 2019

This branch is now known as tb/file-url-to-unc-path.

@gitgitgadget
Copy link

gitgitgadget bot commented Aug 26, 2019

This patch series was integrated into pu via git@3661e96.

@gitgitgadget gitgitgadget bot added the pu label Aug 26, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented Aug 30, 2019

This patch series was integrated into pu via git@4f130fd.

@weekly-digest weekly-digest bot mentioned this pull request Sep 1, 2019
Closed
@gitgitgadget
Copy link

gitgitgadget bot commented Sep 3, 2019

This patch series was integrated into pu via git@c392a2c.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 5, 2019

This patch series was integrated into pu via git@69b620a.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 7, 2019

This patch series was integrated into pu via git@c77f891.

@weekly-digest weekly-digest bot mentioned this pull request Sep 8, 2019
Closed
@gitgitgadget
Copy link

gitgitgadget bot commented Sep 9, 2019

This patch series was integrated into pu via git@7eb4443.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 9, 2019

This patch series was integrated into next via git@13d9c40.

@gitgitgadget gitgitgadget bot added the next label Sep 9, 2019
@weekly-digest weekly-digest bot mentioned this pull request Sep 15, 2019
Closed
@gitgitgadget
Copy link

gitgitgadget bot commented Sep 16, 2019

This patch series was integrated into pu via git@91b3623.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 17, 2019

This patch series was integrated into pu via git@4c340e3.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 18, 2019

This patch series was integrated into pu via git@d1cc9b4.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 18, 2019

This patch series was integrated into pu via git@dc6482c.

@weekly-digest weekly-digest bot mentioned this pull request Sep 22, 2019
Closed
@gitgitgadget
Copy link

gitgitgadget bot commented Sep 30, 2019

This patch series was integrated into pu via git@aadac06.

@gitgitgadget
Copy link

gitgitgadget bot commented Sep 30, 2019

This patch series was integrated into master via git@aadac06.

@gitgitgadget gitgitgadget bot added the master label Sep 30, 2019
@gitgitgadget gitgitgadget bot closed this Sep 30, 2019
@gitgitgadget
Copy link

gitgitgadget bot commented Sep 30, 2019

Closed via aadac06.

@dscho dscho deleted the file-url-to-unc-path branch September 30, 2019 09:44
gitgitgadget bot pushed a commit that referenced this pull request Aug 1, 2024
@pks-t @gitster
t: import the clar unit testing framework
e119e23 
Import the clar unit testing framework at commit faa8419 (Merge pull
request #93 from clar-test/ethomson/fixtures, 2023-12-14). The framework
will be wired up in subsequent commits.

Signed-off-by: Patrick Steinhardt <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
gitgitgadget bot pushed a commit that referenced this pull request Aug 7, 2024
@pks-t @gitster
t: import the clar unit testing framework
b9fae60 
Import the clar unit testing framework at commit faa8419 (Merge pull
request #93 from clar-test/ethomson/fixtures, 2023-12-14). The framework
will be wired up in subsequent commits.

Signed-off-by: Patrick Steinhardt <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
gitgitgadget bot pushed a commit that referenced this pull request Aug 9, 2024
@pks-t @gitster
t: import the clar unit testing framework
5e163fa 
Import the clar unit testing framework at commit faa8419 (Merge pull
request #93 from clar-test/ethomson/fixtures, 2023-12-14). The framework
will be wired up in subsequent commits.

Signed-off-by: Patrick Steinhardt <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
gitgitgadget bot pushed a commit that referenced this pull request Aug 13, 2024
@pks-t @gitster
t: import the clar unit testing framework
68ae49e 
Import the clar unit testing framework at commit faa8419 (Merge pull
request #93 from clar-test/ethomson/fixtures, 2023-12-14). The framework
will be wired up in subsequent commits.

Signed-off-by: Patrick Steinhardt <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
gitgitgadget bot pushed a commit that referenced this pull request Aug 16, 2024
@pks-t @gitster
t: import the clar unit testing framework
0f2fc51 
Import the clar unit testing framework at commit faa8419 (Merge pull
request #93 from clar-test/ethomson/fixtures, 2023-12-14). The framework
will be wired up in subsequent commits.

Signed-off-by: Patrick Steinhardt <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master next pu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dscho @tboegi