Skip to content

Ubuntu exemple with on-premise GHES using network http proxy #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Ubuntu exemple with on-premise GHES using network http proxy #1539

wants to merge 1 commit into from

Conversation

axel3rd
Copy link
Contributor

@axel3rd axel3rd commented Dec 21, 2021

PoC about #1303

Requires #1256

Result can be found here

@axel3rd
Copy link
Contributor Author

axel3rd commented Dec 22, 2021

Set to draft:

  • AWS credentials are useless in user-data template.
  • userdata_pre_install / userdata_post_install could probably be used to pass company + admin PAT temporary

@axel3rd
Copy link
Contributor Author

axel3rd commented Dec 23, 2021

AWS credentials are useless in user-data template.
userdata_pre_install / userdata_post_install could probably be used to pass company + admin PAT temporary

As draft until #1256 review/merge.

@ScottGuymer
Copy link
Contributor

I think it might be useful if this example deployed some kind of proxy that could be used to fully test this config without having to have a proxy configured elsewhere.

@axel3rd
Copy link
Contributor Author

axel3rd commented Jan 26, 2022

I think it might be useful if this example deployed some kind of proxy that could be used to fully test this config without having to have a proxy configured elsewhere.

Agree with the target, but not trivial to achieve 😕.
A VPC should probably be customized (including the proxy), which has direct connection with the customer GHES (could depend of network layers in place).

@ScottGuymer
Copy link
Contributor

Would it work to just have a straight proxy to the internet and test against GH SaaS?

@axel3rd
Copy link
Contributor Author

axel3rd commented Jan 28, 2022

Would it work to just have a straight proxy to the internet and test against GH SaaS?

It is a pure network problem. If on one VPC (which host Lambda [scaleup|scaledown|pool]-runners) we can allow GH SaaS URL but deny AWS API URLs (to "enforce" to use the proxy for runners), I guess yes 🤞.

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label May 10, 2022
@github-actions github-actions bot closed this May 21, 2022
@ScottGuymer ScottGuymer reopened this Jun 1, 2022
@github-actions github-actions bot closed this Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants