Skip to content

[GHSA-78xj-cgh5-2h22] NPM IP package incorrectly identifies some private IP addresses as public #3617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[GHSA-78xj-cgh5-2h22] NPM IP package incorrectly identifies some private IP addresses as public #3617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 7 additions & 25 deletions advisories/github-reviewed/2024/02/GHSA-78xj-cgh5-2h22/GHSA-78xj-cgh5-2h22.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,39 +1,17 @@
{
"schema_version": "1.4.0",
"id": "GHSA-78xj-cgh5-2h22",
"modified": "2024-02-20T18:30:37Z",
"modified": "2024-02-20T18:30:41Z",
"published": "2024-02-08T18:30:39Z",
"aliases": [
"CVE-2023-42282"
],
"summary": "NPM IP package incorrectly identifies some private IP addresses as public",
"details": "The `isPublic()` function in the NPM package `ip` doesn't correctly identify certain private IP addresses in uncommon formats such as `0x7F.1` as private. Instead, it reports them as public by returning `true`. This can lead to security issues such as Server-Side Request Forgery (SSRF) if `isPublic()` is used to protect sensitive code paths when passed user input. Versions 1.1.9 and 2.0.1 fix the issue.",
"details": "The `isPublic()` function in the NPM package `ip` doesn't correctly identify certain private IP addresses in uncommon formats such as `127.1`, `01200034567`, and `0::01` as private. Instead, it reports them as public by returning `true`. This can lead to security issues such as Server-Side Request Forgery (SSRF) if `isPublic()` is used to protect sensitive code paths when passed user input.",
"severity": [

],
"affected": [
{
"package": {
"ecosystem": "npm",
"name": "ip"
},
"ranges": [
{
"type": "ECOSYSTEM",
"events": [
{
"introduced": "2.0.0"
},
{
"fixed": "2.0.1"
}
]
}
],
"versions": [
"2.0.0"
]
},
{
"package": {
"ecosystem": "npm",
Expand All @@ -47,7 +25,7 @@
"introduced": "0"
},
{
"fixed": "1.1.9"
"last_affected": "2.0.1"
}
]
}
Expand All @@ -71,6 +49,10 @@
"type": "WEB",
"url": "https://github.com/indutny/node-ip/pull/138"
},
{
"type": "WEB",
"url": "https://github.com/indutny/node-ip/pull/143"
},
{
"type": "WEB",
"url": "https://github.com/indutny/node-ip/commit/32f468f1245574785ec080705737a579be1223aa"
Expand Down