You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After PR #15 the combobox no longer scrolls when navigating with the arrow keys.
I've made a small example here https://auto-complete-scroll.glitch.me it is the example from this repo, but where I've added a height: 45px; overflow-y: auto; styling to the ul element.
The problem is that the select method in autocomplete.js is no longer called when navigating, so the scrollTo function is never called.
It can be fixed by either moving the scroll functionality to the combobox-nav project instead, or have the combo-box fire an combobox-navigation event and then listen for that and perform the necessary scrolling.
If one of the proposed methods are suitable, I can submit a PR.
The text was updated successfully, but these errors were encountered:
bnjamin
changed the title
The
The combobox doesn't scroll on navigation
Jun 26, 2019
bnjamin
changed the title
The combobox doesn't scroll on navigation
The combobox doesn't scroll when navigating
Jun 26, 2019
Uh oh!
There was an error while loading. Please reload this page.
After PR #15 the combobox no longer scrolls when navigating with the arrow keys.
I've made a small example here https://auto-complete-scroll.glitch.me it is the example from this repo, but where I've added a
height: 45px; overflow-y: auto;
styling to theul
element.The problem is that the select method in
autocomplete.js
is no longer called when navigating, so thescrollTo
function is never called.It can be fixed by either moving the scroll functionality to the combobox-nav project instead, or have the combo-box fire an
combobox-navigation
event and then listen for that and perform the necessary scrolling.If one of the proposed methods are suitable, I can submit a PR.
The text was updated successfully, but these errors were encountered: