Skip to content

Conversation

@xeago
Copy link
Contributor

@xeago xeago commented Feb 4, 2015

No description provided.

@xeago
Copy link
Contributor Author

xeago commented Feb 5, 2015

When building/testing inside a chroot, the package devscripts wasn't installed. It however is needed as a dependency for building this package.

We use sbuild to build using a single-use chroot, the package not being in the build dependencies causes a build failure when running checkbashisms.

@xeago xeago changed the title Add devscripts to debian's build-depends for devscripts Add devscripts to debian's build-depends for checkbashisms Feb 5, 2015
@xeago
Copy link
Contributor Author

xeago commented May 10, 2015

Can this be merged? This is the equivalent of why we install devscripts in travis: https://github.com/github/backup-utils/blame/master/.travis.yml#L6

It is blocking us from upgrading our internal package - we don't want to maintain separate patches to our fork.

@rtomayko
Copy link
Contributor

Yep, super sorry. I missed this when it came through somehow.

rtomayko added a commit that referenced this pull request May 11, 2015
Add devscripts to debian's build-depends for checkbashisms
@rtomayko rtomayko merged commit ea8e860 into github:master May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants