Skip to content

Conversation

@lildude
Copy link
Member

@lildude lildude commented Feb 17, 2015

Backing up Pages over rsync when the appliance has no Pages and Pages is disabled results in an error on certain operating systems:

$ bin/ghe-backup
Starting backup of ghe.example.com in snapshot 20150217T222343
Connect ghe.example.com:122 OK (v2.1.2)
Backing up GitHub settings ...
Backing up SSH authorized keys ...
Backing up SSH host keys ...
Backing up MySQL database ...
Backing up Redis database ...
Backing up Git repositories ...
Backing up GitHub Pages ...
--link-dest arg does not exist: ../../current/pages
Backing up asset attachments ...
Backing up hook deliveries ...
Backing up Elasticsearch indices ...
Pruning 1 expired snapshot(s) ...
Completed backup of ghe.example.com:122 in snapshot 20150217T222343 at 22:24:45

This is readily reproducible on RedHat/CentOS 6.

This PR resolves this for all platforms by ensuring the pages backup directory already exists before an attempt is made to backup the contents.

@rtomayko
Copy link
Contributor

👍

rtomayko added a commit that referenced this pull request Feb 19, 2015
@rtomayko rtomayko merged commit 9b7e4ab into master Feb 19, 2015
@rubiojr rubiojr deleted the fix-pages-backup-centos branch February 25, 2016 17:26
juruen pushed a commit that referenced this pull request Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants