Remove temporary 2.2 migration dir before restoring repos #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Locally tests are failing. I'll investigate further and update this PR. |
Member
Author
|
Fixed. It was a silly syntax error. All should be good now. |
Contributor
There was a problem hiding this comment.
We can axe the if here too. rm -rf will exit non-zero when the directory doesn't exist.
Contributor
There was a problem hiding this comment.
Actually, let's leave it. The sudo will cause problems on GHE < 2.0 and I don't think it's worth wrapping in a version check.
rtomayko
added a commit
that referenced
this pull request
May 13, 2015
Remove temporary 2.2 migration dir before restoring repos
cjonsmith
pushed a commit
that referenced
this pull request
Sep 22, 2020
Relax 2.11 & 2.12 minimum required versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the temporary /data/user/repositories-nw-backup directory that remains after successfully migrating the repository storage layout to the new format used on GHE 2.2.0 and later.
The removal of this directory allows for continual restoration to work on GHE 2.2.x.
/cc @rtomayko