Skip to content

Minimum version enforcement for cluster restores #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubiojr merged 14 commits into from
Mar 30, 2016
Merged

Minimum version enforcement for cluster restores #182

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
37f816f
Minimum version enforcement for cluster restores
snh Mar 19, 2016
a2884e9
Fix wording in error
snh Mar 19, 2016
3ac2327
Add clustering tests
gnawhleinad Mar 19, 2016
634323d
Fix paths to ghe-backup-config and testlib.sh
gnawhleinad Mar 19, 2016
7153f0d
Test on a 2.4.0 snapshot
gnawhleinad Mar 19, 2016
ea4b921
Add clustering tests
gnawhleinad Mar 19, 2016
70537d4
Merge branch 'gnawhleinad/add-cluster-test'
gnawhleinad Mar 19, 2016
403733b
rm test/cluster
gnawhleinad Mar 19, 2016
d78bff2
Test on a 2.5.0 snapshot
gnawhleinad Mar 19, 2016
5e0c82e
Add ghe-cluster-config-apply stub
gnawhleinad Mar 19, 2016
47be7e1
Update with @snh's feedback
gnawhleinad Mar 19, 2016
acf069f
Merge pull request #183 from github/gnawhleinad/add-cluster-test
gnawhleinad Mar 19, 2016
676ecc3
Merge branch 'master' into snh/cluster-restore-version-check
snh Mar 30, 2016
086ff39
Change to bash for new test
snh Mar 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions bin/ghe-restore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,17 @@ if ghe-ssh "$GHE_HOSTNAME" -- \
restore_settings=false
fi

# Figure out if we're restoring into a cluster with an unsupported snapshot
if $cluster; then
snapshot_instance_version=$(cat $GHE_RESTORE_SNAPSHOT_PATH/version)
if ! echo $snapshot_instance_version | \
grep -Eq "v2\.[5-9]|v2\.[1-9][0-9]|v[3-9]|v[1-9][0-9]"; then
Copy link
Member

@rubiojr rubiojr Mar 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminded me that we need to add a semver comparison helper at some point, somewhere. The ^^^ regex may not be future proof :trollface:, but who wants to live forever.

echo "Error: Snapshot must be from GitHub Enterprise v2.5.0 and above to be restored"
Copy link
Contributor

@gnawhleinad gnawhleinad Mar 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2.5.0 or above

echo " into a cluster (detected $snapshot_instance_version). Aborting." >&2
exit 1
fi
fi

# Figure out if this instance is in a replication pair
if ghe-ssh "$GHE_HOSTNAME" -- "ghe-repl-status -r 2>/dev/null" \
| grep -Eq "replica|primary"; then
Expand Down