ghe-restore: check maintenance mode is enabled. #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do this instead of just enabling it unconditionally.
Fixes #62.
Contributor
There was a problem hiding this comment.
Quote the path name here just in case GHE_REMOTE_DATA_DIR has spaces in dev / test environments.
Contributor
|
Nice. Diff looks good to me the one quoting issue aside. 👍 |
Handle the case in which it might have spaces.
MikeMcQuaid
added a commit
that referenced
this pull request
Dec 9, 2014
ghe-restore: check maintenance mode is enabled.
snh
pushed a commit
that referenced
this pull request
Aug 7, 2017
* Skip hookshot es backup on pre 2.0 * Only restore hookshot es backup to cluster * Correct minor spelling error * Backup and restore ca certificates * Don't suppress output * Check if command exists so to expose errors * Backup not restore * Use which instead of type to verify existence * Silence test output * Run bm_file_path first * Revert removal of bm_file_path from bm_start In case bm.sh is used outside or independently of ghe-backup or ghe-restore, such as when testing backup utilities individual components. * Rename bm_file_path to bm_init Should make the intention a bit more clear. * Add --version flag to all commands * Check for missing GHE_DATA_DIR variable in config ``` $ ./bin/ghe-backup ./bin/../share/github-backup-utils/ghe-backup-config: line 82: [: !=: unary operator expected mkdir: : No such file or directory ``` These errors occur because `GHE_DATA_DIR` is not defined before running`ghe-backup-config`, causing it to throw errors. ``` $ ./share/github-backup-utils/ghe-backup-config ./share/github-backup-utils/ghe-backup-config: line 82: [: !=: unary operator expected mkdir: : No such file or directory Error: GHE_DATA_DIR does not exist. ``` This change adds a test to ensure `GHE_DATA_DIR` is defined, else return an appropriate error. ``` $ ./bin/ghe-backup Error: GHE_DATA_DIR not set in config file. $ ./share/github-backup-utils/ghe-backup-config Error: GHE_DATA_DIR not set in config file. ``` * Check backup-utils are not being run on GitHub Enterprise host Customers occasionally configure backup-utils to run on the GitHub Enterprise host or HA replica. Apart from losing their backup if the appliance is lost, it leads to running out of disk space issues. This PR adds a check for this case and returns an informative error to guide the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do this instead of just enabling it unconditionally.
Fixes #62.
CC @rtomayko for review.