Skip to content

Update eslint and friends #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Update eslint and friends #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d3f328
upgrade eslint and friends
keithamus Mar 28, 2022
dd352bb
turn off unecessary lint rules for this package
keithamus Mar 28, 2022
4cf4f01
fix lint errors
keithamus Mar 28, 2022
1935501
fix typescript errors
keithamus Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
"plugins": ["github"],
"extends": ["plugin:github/recommended", "plugin:github/typescript", "plugin:github/browser"],
"rules": {
"no-invalid-this": "off",
"@typescript-eslint/no-invalid-this": ["error"],
"import/no-unresolved": "off",
"github/no-inner-html": "off",
"i18n-text/no-en": "off",
"import/extensions": ["error", "ignorePackages"],
"@typescript-eslint/consistent-type-imports": ["error", {"prefer": "type-imports"}]
},
Expand All @@ -24,6 +25,9 @@
},
{
"files": "*.cjs",
"rules": {
"import/no-commonjs": "off"
},
"env": {
"node": true
}
Expand Down
2 changes: 1 addition & 1 deletion docs/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
function storeColorSchemePreference() {
// Get color scheme preference from URL
const url = new URL(window.location.href)
const url = new URL(window.location.href, window.location.origin)
const params = new URLSearchParams(url.search)

// Return early if there’s nothing to store
Expand Down
Loading