Skip to content

Return void from target decorators #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2022
Merged

Return void from target decorators #195

merged 1 commit into from
Apr 4, 2022

Conversation

jdanyow
Copy link
Contributor

@jdanyow jdanyow commented Apr 4, 2022

Fixes #194

@jdanyow jdanyow requested a review from a team as a code owner April 4, 2022 00:59
@jdanyow jdanyow requested a review from manuelpuyol April 4, 2022 00:59
koddsson
koddsson approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

@koddsson koddsson merged commit a8fb3ba into github:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelpuyol manuelpuyol Awaiting requested review from manuelpuyol manuelpuyol was automatically assigned from github/ui-frameworks-reviewers

1 more reviewer

@koddsson koddsson koddsson approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript error TS1271: Decorator function return type is 'Record<..., unknown>' but is expected to be 'void' or 'any'.
2 participants
@jdanyow @koddsson