Skip to content

Cherry-pick attr tests from use-delegates. #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 6, 2022
Merged

Cherry-pick attr tests from use-delegates. #228

merged 4 commits into from
May 6, 2022

Conversation

koddsson
Copy link
Contributor

@koddsson koddsson commented May 6, 2022

This will make merging use-delegates a easier lift.

@koddsson koddsson requested a review from a team as a code owner May 6, 2022 19:03
@koddsson koddsson requested a review from srt32 May 6, 2022 19:03
keithamus
keithamus approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@keithamus keithamus enabled auto-merge May 6, 2022 19:05
@keithamus keithamus merged commit a399966 into main May 6, 2022
@keithamus keithamus deleted the update-attr-tests branch May 6, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srt32 srt32 Awaiting requested review from srt32 srt32 was automatically assigned from github/web-systems-reviewers

1 more reviewer

@keithamus keithamus keithamus approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koddsson @keithamus