split out ability & controllable #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
force-pushed
the
split-ability-controllable
branch
from
d282a75 to
cad5293
Compare
keithamus
force-pushed
the
split-ability-controllable
branch
from
cad5293 to
776c022
Compare
koddsson
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change splits out
createAbilityandcontrollable(which was poorly namedabilitableprior to this change) into separate files. It also cleans up the types and some of the semantics, in ways which would be breaking if this code was exported or released. Thankfully it hasn’t been so we can safely clean this up into some much better code.