Match targets exactly #39
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the component and markup:
the component will log
<div data-action="my-controller.foobar"></div>
once it's connected even though we obviously wanted the other target.This is because we are using a attribute selector that just checks that the attribute value contains the given value. Since
foobar
containsfoo
and it appears first in the DOM we'll return that even thought the user wanted the other target.This change removes the contains attribute selector and just matches the data attribute value exactly.
Ref: https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute_selectors