Feature: Automatically attach shadow roots with <template data-shadowroot>
#74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This allows for components which contain a
<template data-shadowroot>element to automatically render a shadowRoot with the contents of the template.Why?
This enables us to implement elements with a shadowDOM much easier than the potentially difficult to use ShadowDOM api of
this.attachShadow({ mode: 'open' }).appendChild(template.content.cloneNode(true). This line is very complex and elides many of its own details (what is mode? why is it open? Why do we passtrueto cloneNode?)This also gets us quite close to the "declarative shadow DOM" apis that are currently being proposed - but without holding oursevles to a spec conformant implementation. We may one day deprecate
data-shadowrootin favour of simply using the proposedshadowrootattribute.