Auto call listenForBind #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This change adds
listenForBind(element.ownerDocument)to any element that callsbind(element). Calls tolistenForBindare then memoized by node, so we don't oversubscribe to documents. This effectively means each document an element is added to will be registered (typically this is 1).listenForBindis still left as an exported member, as are all of our functions, and the documentation has been clarified on how it can be used for some extremely rare cases, should it need to be. The doc also importantly describes how it is automatically called onownerDocument.This is a non-breaking change, in the sense that if we ship this we need to make no additional code changes; as any current calls of
listenForBind(document)will be memoized away.Why?
We've had
listenForBind(document)running in production for a while now with no performance issues that we know of. I'd consider this stable enough to "ship" by default.