Merge pull request #23 from github/fix-cachedir-trailing-slash

Fix an issue with trailing path separators in the `--cache-dir` argument.

Author: chrisgavin

internal/cachedirectory/cachedirectory.go

@@ -25,7 +25,7 @@ type CacheDirectory struct {
 
 func NewCacheDirectory(path string) CacheDirectory {
 	return CacheDirectory{
-		path: path,
+		path: filepath.Clean(path),
 	}
 }
 

internal/cachedirectory/cachedirectory_test.go

@@ -81,3 +81,10 @@ func TestErrorIfPushNonExistent(t *testing.T) {
 	err := cacheDirectory.CheckOrCreateVersionFile(false, aVersion)
 	require.EqualError(t, err, errorPushNonCache)
 }
+
+func TestCreateCacheDirectoryWithTrailingSlash(t *testing.T) {
+	temporaryDirectory := test.CreateTemporaryDirectory(t)
+	cacheDirectory := NewCacheDirectory(path.Join(temporaryDirectory, "cache") + string(os.PathSeparator))
+	err := cacheDirectory.CheckOrCreateVersionFile(true, aVersion)
+	require.NoError(t, err)
+}