Fix an issue with trailing path separators in the --cache-dir
argument.
#23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where using a non-existent cache directory behaves differently depending on whether it has a trailing slash.
Before this change, using a trailing slash would always give an error because we check if the parent (as determined by
filepath.Dir(...)
exists before creating the cache directory. When a path has a trailing slash,filepath.Dir(...)
returns the input path. This is a Go bug in my opinion.To work around this issue, I've called
filepath.Clean(...)
on the path before we initialize the cache, which strips any trailing slashes. I've also added a test for this case.