Rust: Make SummarizedCallable extend Function instead of string
#19268
+857
−998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1017,3 +1017,26 @@ | |||
| * Gets a type that `n` infers to, if any. | |||
| */ | |||
| Type inferType(AstNode n) { result = inferType(n, TypePath::nil()) } | |||
|
|
|||
| /** Provides predicates for debugging the type inference implementation. */ | |||
| private module Debug { | |||
Check warning
Code scanning / CodeQL
Dead code Warning
| /** Provides predicates for debugging the type inference implementation. */ | ||
| private module Debug { | ||
| private Locatable getRelevantLocatable() { | ||
| exists(string filepath, int startline, int startcolumn, int endline, int endcolumn | |
Check warning
Code scanning / CodeQL
Omittable 'exists' variable Warning
| /** Provides predicates for debugging the type inference implementation. */ | ||
| private module Debug { | ||
| private Locatable getRelevantLocatable() { | ||
| exists(string filepath, int startline, int startcolumn, int endline, int endcolumn | |
Check warning
Code scanning / CodeQL
Omittable 'exists' variable Warning
| /** Provides predicates for debugging the type inference implementation. */ | ||
| private module Debug { | ||
| private Locatable getRelevantLocatable() { | ||
| exists(string filepath, int startline, int startcolumn, int endline, int endcolumn | |
Check warning
Code scanning / CodeQL
Omittable 'exists' variable Warning
hvitved
force-pushed
the
rust/summarized-callable-base
branch
3 times, most recently
from
86ccc96 to
a91cc6b
Compare
hvitved
force-pushed
the
rust/summarized-callable-base
branch
4 times, most recently
from
d8b7085 to
10a72f7
Compare
hvitved
force-pushed
the
rust/summarized-callable-base
branch
3 times, most recently
from
9b1cd94 to
2a2e7d5
Compare
hvitved
force-pushed
the
rust/summarized-callable-base
branch
3 times, most recently
from
e0a2c1d to
dc9700e
Compare
hvitved
force-pushed
the
rust/summarized-callable-base
branch
from
dc9700e to
4224947
Compare
hvitved
force-pushed
the
rust/summarized-callable-base
branch
4 times, most recently
from
b0991ad to
c29c5f9
Compare
hvitved
force-pushed
the
rust/summarized-callable-base
branch
8 times, most recently
from
c1959ca to
73c4919
Compare
hvitved
force-pushed
the
rust/summarized-callable-base
branch
4 times, most recently
from
c79d3a9 to
afa16ea
Compare
hvitved
force-pushed
the
rust/summarized-callable-base
branch
from
afa16ea to
58cd7b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the base class of
SummarizedCallablefromstringtoFunction, thereby reusing the existing function entities already extracted instead of synthesizing new entities.This is a big step towards using QL computed canonical paths in models-as-data instead of using extractor provided canonical paths.
A lot of preliminary PRs mean that we mostly retain results, however as witnessed by the tests, we still lose some results. This is largely because:
impl<T> Foo for T.Derefs in type inference.