-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Rust: update docs for public preview #19280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
00f6d9b
Rust: start preparing documentation changes
df427f7
Rust: add supported frameworks file
33c857c
Rust: update supported languages footnote
e2a86aa
Rust: update supported libraries
redsun82 00f4bfd
Rust: add some more supported libraries
redsun82 779d06f
Merge branch 'main' into redsun82/rust-doc
redsun82 c70decb
Rust: add `Callable::getParam` and `CallExprBase::getArg` shortcuts
redsun82 f3e4f94
Rust: add documentation
redsun82 9c2fea9
Rust: accept test changes
redsun82 f647b33
Rust: rerun codegen
redsun82 48721dc
Merge branch 'main' into redsun82/rust-doc
redsun82 3fe6ba6
Revert "Rust: add `Callable::getParam` and `CallExprBase::getArg` sho…
redsun82 b6aa692
Revert "Rust: accept test changes"
redsun82 02c11b1
Revert "Rust: rerun codegen"
redsun82 902a421
Rust: fix docs with `getArgList` and `getParamList`
redsun82 e1e34df
Merge branch 'main' into redsun82/rust-doc
redsun82 c56a325
Rust: remove now unneeded `get(Arg|Param)List` in the dataflow guide
redsun82 cae4a04
Rust: update `supported-frameworks.rst`
redsun82 ad3a5d7
Rust: add public preview change notes
redsun82 e9a0710
Rust: address review on docs
redsun82 494d192
Merge branch 'main' into redsun82/rust-doc
redsun82 e011475
Rust: fix formatting in doc snippet
redsun82 7a9f23c
Rust: fix `sphinx` error
redsun82 11af770
Merge branch 'main' into redsun82/rust-doc
redsun82 f812b64
Rust: address review
redsun82 9c06a82
Rust: apply suggestions from code review
redsun82 bd0d996
Merge branch 'main' into redsun82/rust-doc
redsun82 915b0b3
Update docs/codeql/codeql-language-guides/analyzing-data-flow-in-rust…
redsun82 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
300 changes: 300 additions & 0 deletions
300
docs/codeql/codeql-language-guides/analyzing-data-flow-in-rust.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,300 @@ | ||
.. _analyzing-data-flow-in-rust: | ||
|
||
Analyzing data flow in Rust | ||
============================= | ||
|
||
You can use CodeQL to track the flow of data through a Rust program to places where the data is used. | ||
|
||
About this article | ||
------------------ | ||
|
||
This article describes how data flow analysis is implemented in the CodeQL libraries for Rust and includes examples to help you write your own data flow queries. | ||
The following sections describe how to use the libraries for local data flow, global data flow, and taint tracking. | ||
For a more general introduction to modeling data flow, see ":ref:`About data flow analysis <about-data-flow-analysis>`." | ||
|
||
.. include:: ../reusables/new-data-flow-api.rst | ||
|
||
Local data flow | ||
--------------- | ||
|
||
Local data flow tracks the flow of data within a single method or callable. Local data flow is easier, faster, and more precise than global data flow. Before looking at more complex tracking, you should always consider local tracking because it is sufficient for many queries. | ||
|
||
Using local data flow | ||
~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
You can use the local data flow library by importing the ``codeql.rust.dataflow.DataFlow`` module. The library uses the class ``Node`` to represent any element through which data can flow. | ||
``Node``\ s are divided into expression nodes (``ExprNode``) and parameter nodes (``ParameterNode``). | ||
geoffw0 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
You can map a data flow ``ParameterNode`` to its corresponding ``Parameter`` AST node using the ``asParameter`` member predicate. | ||
Similarly, you can use the ``asExpr`` member predicate to map a data flow ``ExprNode`` to its corresponding ``ExprCfgNode`` in the control-flow library. | ||
geoffw0 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
.. code-block:: ql | ||
|
||
class Node { | ||
/** Gets the expression corresponding to this node, if any. */ | ||
CfgNodes::ExprCfgNode asExpr() { ... } | ||
|
||
/** Gets the parameter corresponding to this node, if any. */ | ||
Parameter asParameter() { ... } | ||
|
||
... | ||
} | ||
|
||
You can use the predicates ``exprNode`` and ``parameterNode`` to map from expressions and parameters to their data-flow node: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I actually don't think those predicates exist yet. |
||
|
||
.. code-block:: ql | ||
|
||
/** | ||
* Gets a node corresponding to expression `e`. | ||
*/ | ||
ExprNode exprNode(CfgNodes::ExprCfgNode e) { ... } | ||
|
||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
/** | ||
* Gets the node corresponding to the value of parameter `p` at function entry. | ||
*/ | ||
ParameterNode parameterNode(Parameter p) { ... } | ||
|
||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Note that since ``asExpr`` and ``exprNode`` map between data-flow and control-flow nodes, you then need to call the ``getExpr`` member predicate on the control-flow node to map to the corresponding AST node, | ||
for example, by writing ``node.asExpr().getExpr()``. | ||
A control-flow graph considers every way control can flow through code, consequently, there can be multiple data-flow and control-flow nodes associated with a single expression node in the AST. | ||
|
||
The predicate ``localFlowStep(Node nodeFrom, Node nodeTo)`` holds if there is an immediate data flow edge from the node ``nodeFrom`` to the node ``nodeTo``. | ||
You can apply the predicate recursively, by using the ``+`` and ``*`` operators, or you can use the predefined recursive predicate ``localFlow``. | ||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
For example, you can find flow from an expression ``source`` to an expression ``sink`` in zero or more local steps: | ||
|
||
.. code-block:: ql | ||
|
||
DataFlow::localFlow(source, sink) | ||
|
||
Using local taint tracking | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
Local taint tracking extends local data flow to include flow steps where values are not preserved, for example, string manipulation. | ||
For example: | ||
|
||
.. code-block:: rust | ||
|
||
let y: String = "Hello ".to_owned() + x | ||
|
||
If ``x`` is a tainted string then ``y`` is also tainted. | ||
|
||
The local taint tracking library is in the module ``TaintTracking``. | ||
Like local data flow, a predicate ``localTaintStep(DataFlow::Node nodeFrom, DataFlow::Node nodeTo)`` holds if there is an immediate taint propagation edge from the node ``nodeFrom`` to the node ``nodeTo``. | ||
You can apply the predicate recursively, by using the ``+`` and ``*`` operators, or you can use the predefined recursive predicate ``localTaint``. | ||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
For example, you can find taint propagation from an expression ``source`` to an expression ``sink`` in zero or more local steps: | ||
|
||
.. code-block:: ql | ||
|
||
TaintTracking::localTaint(source, sink) | ||
|
||
|
||
Using local sources | ||
~~~~~~~~~~~~~~~~~~~ | ||
|
||
When exploring local data flow or taint propagation between two expressions as above, you would normally constrain the expressions to be relevant to your investigation. | ||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
The next section gives some concrete examples, but first it's helpful to introduce the concept of a local source. | ||
|
||
A local source is a data-flow node with no local data flow into it. | ||
As such, it is a local origin of data flow, a place where a new value is created. | ||
This includes parameters (which only receive values from global data flow) and most expressions (because they are not value-preserving). | ||
The class ``LocalSourceNode`` represents data-flow nodes that are also local sources. | ||
It comes with a useful member predicate ``flowsTo(DataFlow::Node node)``, which holds if there is local data flow from the local source to ``node``. | ||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Examples of local data flow | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
This query finds the argument passed in each call to ``File::create``: | ||
|
||
.. code-block:: ql | ||
|
||
import rust | ||
|
||
from CallExpr call | ||
where call.getStaticTarget().(Function).getCanonicalPath() = "<std::fs::File>::create" | ||
select call.getArg(0) | ||
|
||
Unfortunately this will only give the expression in the argument, not the values which could be passed to it. | ||
So we use local data flow to find all expressions that flow into the argument: | ||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
.. code-block:: ql | ||
|
||
import rust | ||
import codeql.rust.dataflow.DataFlow | ||
|
||
from CallExpr call, DataFlow::ExprNode source, DataFlow::ExprNode sink | ||
where | ||
call.getStaticTarget().(Function).getCanonicalPath() = "<std::fs::File>::create" and | ||
sink.asExpr().getExpr() = call.getArg(0) and | ||
DataFlow::localFlow(source, sink) | ||
select source, sink | ||
|
||
We can vary the source, for example, making the source the parameter of a function rather than an expression. The following query finds where a parameter is used for the file creation: | ||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
.. code-block:: ql | ||
|
||
import rust | ||
import codeql.rust.dataflow.DataFlow | ||
|
||
from CallExpr call, Method method, ParamDecl sourceParam, Expr sinkExpr | ||
where | ||
call.getStaticTarget() = method and | ||
method.hasQualifiedName("String", "init(format:_:)") and | ||
sinkExpr = call.getArgument(0).getExpr() and | ||
DataFlow::localFlow(DataFlow::parameterNode(sourceParam), DataFlow::exprNode(sinkExpr)) | ||
select sourceParam, sinkExpr | ||
|
||
The following example finds calls to ``String.init(format:_:)`` where the format string is not a hard-coded string literal: | ||
|
||
.. code-block:: ql | ||
|
||
import rust | ||
import codeql.rust.dataflow.DataFlow | ||
|
||
from CallExpr call, Method method, DataFlow::Node sinkNode | ||
where | ||
call.getStaticTarget() = method and | ||
method.hasQualifiedName("String", "init(format:_:)") and | ||
sinkNode.asExpr() = call.getArgument(0).getExpr() and | ||
not exists(StringLiteralExpr sourceLiteral | | ||
DataFlow::localFlow(DataFlow::exprNode(sourceLiteral), sinkNode) | ||
) | ||
select call, "Format argument to " + method.getName() + " isn't hard-coded." | ||
|
||
Global data flow | ||
---------------- | ||
|
||
Global data flow tracks data flow throughout the entire program, and is therefore more powerful than local data flow. | ||
However, global data flow is less precise than local data flow, and the analysis typically requires significantly more time and memory to perform. | ||
|
||
.. pull-quote:: Note | ||
|
||
.. include:: ../reusables/path-problem.rst | ||
|
||
Using global data flow | ||
~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
We can use the global data flow library by implementing the signature ``DataFlow::ConfigSig`` and applying the module ``DataFlow::Global<ConfigSig>``: | ||
|
||
.. code-block:: ql | ||
|
||
import codeql.rust.dataflow.DataFlow | ||
|
||
module MyDataFlowConfiguration implements DataFlow::ConfigSig { | ||
predicate isSource(DataFlow::Node source) { | ||
... | ||
} | ||
|
||
predicate isSink(DataFlow::Node sink) { | ||
... | ||
} | ||
} | ||
|
||
module MyDataFlow = DataFlow::Global<MyDataFlowConfiguration>; | ||
|
||
These predicates are defined in the configuration: | ||
|
||
- ``isSource`` - defines where data may flow from. | ||
- ``isSink`` - defines where data may flow to. | ||
- ``isBarrier`` - optional, defines where data flow is blocked. | ||
- ``isAdditionalFlowStep`` - optional, adds additional flow steps. | ||
|
||
The last line (``module MyDataFlow = ...``) instantiates the parameterized module for data flow analysis by passing the configuration to the parameterized module. Data flow analysis can then be performed using ``MyDataFlow::flow(DataFlow::Node source, DataFlow::Node sink)``: | ||
|
||
.. code-block:: ql | ||
|
||
from DataFlow::Node source, DataFlow::Node sink | ||
where MyDataFlow::flow(source, sink) | ||
select source, "Dataflow to $@.", sink, sink.toString() | ||
|
||
Using global taint tracking | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
Global taint tracking is to global data flow what local taint tracking is to local data flow. | ||
That is, global taint tracking extends global data flow with additional non-value-preserving steps. | ||
The global taint tracking library uses the same configuration module as the global data flow library. You can perform taint flow analysis using ``TaintTracking::Global``: | ||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
.. code-block:: ql | ||
|
||
module MyTaintFlow = TaintTracking::Global<MyDataFlowConfiguration>; | ||
|
||
from DataFlow::Node source, DataFlow::Node sink | ||
where MyTaintFlow::flow(source, sink) | ||
select source, "Taint flow to $@.", sink, sink.toString() | ||
|
||
Predefined sources | ||
~~~~~~~~~~~~~~~~~~ | ||
|
||
The data flow library module ``codeql.rust.dataflow.FlowSources`` contains a number of predefined sources that you can use to write security queries to track data flow and taint flow. | ||
|
||
- The class ``RemoteFlowSource`` represents data flow from remote network inputs and from other applications. | ||
- The class ``LocalFlowSource`` represents data flow from local user input. | ||
- The class ``FlowSource`` includes both of the above. | ||
geoffw0 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Examples of global data flow | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
The following global taint-tracking query finds places where a string literal is used in a function call argument named "password". | ||
- Since this is a taint-tracking query, the ``TaintTracking::Global`` module is used. | ||
- The ``isSource`` predicate defines sources as any ``StringLiteralExpr``. | ||
- The ``isSink`` predicate defines sinks as arguments to a ``CallExpr`` called "password". | ||
- The sources and sinks may need tuning to a particular use, for example, if passwords are represented by a type other than ``String`` or passed in arguments of a different name than "password". | ||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
.. code-block:: ql | ||
|
||
import rust | ||
import codeql.rust.dataflow.DataFlow | ||
import codeql.rust.dataflow.TaintTracking | ||
|
||
module ConstantPasswordConfig implements DataFlow::ConfigSig { | ||
predicate isSource(DataFlow::Node node) { node.asExpr() instanceof StringLiteralExpr } | ||
|
||
predicate isSink(DataFlow::Node node) { | ||
// any argument called `password` | ||
exists(CallExpr call | call.getArgumentWithLabel("password").getExpr() = node.asExpr()) | ||
} | ||
|
||
module ConstantPasswordFlow = TaintTracking::Global<ConstantPasswordConfig>; | ||
|
||
from DataFlow::Node sourceNode, DataFlow::Node sinkNode | ||
where ConstantPasswordFlow::flow(sourceNode, sinkNode) | ||
select sinkNode, "The value $@ is used as a constant password.", sourceNode, sourceNode.toString() | ||
|
||
|
||
The following global taint-tracking query finds places where a value from a remote or local user input is used as an argument to the SQLite ``Connection.execute(_:)`` function. | ||
- Since this is a taint-tracking query, the ``TaintTracking::Global`` module is used. | ||
- The ``isSource`` predicate defines sources as a ``FlowSource`` (remote or local user input). | ||
- The ``isSink`` predicate defines sinks as the first argument in any call to ``Connection.execute(_:)``. | ||
|
||
.. code-block:: ql | ||
|
||
import rust | ||
import codeql.rust.dataflow.DataFlow | ||
import codeql.rust.dataflow.TaintTracking | ||
import codeql.rust.dataflow.FlowSources | ||
|
||
module SqlInjectionConfig implements DataFlow::ConfigSig { | ||
predicate isSource(DataFlow::Node node) { node instanceof FlowSource } | ||
|
||
predicate isSink(DataFlow::Node node) { | ||
exists(CallExpr call | | ||
call.getStaticTarget().(Method).hasQualifiedName("Connection", "execute(_:)") and | ||
call.getArgument(0).getExpr() = node.asExpr() | ||
) | ||
} | ||
} | ||
|
||
module SqlInjectionFlow = TaintTracking::Global<SqlInjectionConfig>; | ||
|
||
from DataFlow::Node sourceNode, DataFlow::Node sinkNode | ||
where SqlInjectionFlow::flow(sourceNode, sinkNode) | ||
select sinkNode, "This query depends on a $@.", sourceNode, "user-provided value" | ||
|
||
Further reading | ||
--------------- | ||
|
||
- `Exploring data flow with path queries <https://docs.github.com/en/code-security/codeql-for-vs-code/getting-started-with-codeql-for-vs-code/exploring-data-flow-with-path-queries>`__ in the GitHub documentation. | ||
|
||
|
||
.. include:: ../reusables/rust-further-reading.rst | ||
.. include:: ../reusables/codeql-ref-tools-further-reading.rst |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
|
||
.. _codeql-for-rust: | ||
|
||
CodeQL for Rust | ||
========================= | ||
|
||
Experiment and learn how to write effective and efficient queries for CodeQL databases generated from Rust code. | ||
|
||
.. toctree:: | ||
:hidden: | ||
|
||
codeql-library-for-rust | ||
analyzing-data-flow-in-rust | ||
|
||
- :doc:`CodeQL library for Rust <codeql-library-for-rust>`: When you're analyzing Rust code, you can make use of the large collection of classes in the CodeQL library for Rust. | ||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- :doc:`Analyzing data flow in Ruby <analyzing-data-flow-in-rust>`: You can use CodeQL to track the flow of data through a Rust program to places where the data is used. | ||
geoffw0 marked this conversation as resolved.
Show resolved
Hide resolved
|
62 changes: 62 additions & 0 deletions
62
docs/codeql/codeql-language-guides/codeql-library-for-rust.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
.. _codeql-library-for-rust: | ||
|
||
CodeQL library for Rust | ||
================================= | ||
|
||
When you're analyzing Rust code, you can make use of the large collection of classes in the CodeQL library for Rust. | ||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Overview | ||
-------- | ||
|
||
CodeQL ships with a library for analyzing Rust code. The classes in this library present the data from a CodeQL database in an object-oriented form and provide | ||
abstractions and predicates to help you with common analysis tasks. | ||
|
||
The library is implemented as a set of CodeQL modules, that is, files with the extension ``.qll``. The | ||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
module `rust.qll <https://github.com/github/codeql/blob/main/rust/ql/lib/rust.qll>`__ imports most other standard library modules, so you can include the complete | ||
library by beginning your query with: | ||
geoffw0 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
.. code-block:: ql | ||
|
||
import rust | ||
|
||
The CodeQL libraries model various aspects of Rust code. The above import includes the abstract syntax tree (AST) library, which is used for locating program elements, | ||
to match syntactic elements in the source code. This can be used for example to find values, patterns and structures. | ||
geoffw0 marked this conversation as resolved.
Show resolved
Hide resolved
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
The control flow graph (CFG) is imported using | ||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
.. code-block:: ql | ||
|
||
import codeql.rust.controlflow.ControlFlowGraph | ||
|
||
The CFG models the control flow between statements and expressions, for example whether one expression can | ||
be evaluated before another expression, or whether an expression "dominates" another one, meaning that all paths to an | ||
expression must flow through another expression first. | ||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
The data flow library is imported using | ||
redsun82 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
.. code-block:: ql | ||
|
||
import codeql.rust.dataflow.DataFlow | ||
|
||
Data flow tracks the flow of data through the program, including through function calls (interprocedural data flow) and between steps in a job or workflow. | ||
Data flow is particularly useful for security queries, where untrusted data flows to vulnerable parts of the program | ||
to exploit it. Related to data flow, is the taint-tracking library, which finds how data can *influence* other values | ||
geoffw0 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
in a program, even when it is not copied exactly. | ||
|
||
To summarize, the main Rust library modules are: | ||
|
||
.. list-table:: Main Rust library modules | ||
:header-rows: 1 | ||
|
||
* - Import | ||
- Description | ||
* - ``rust`` | ||
- The standard Rust library | ||
* - ``codeql.rust.elements`` | ||
- The abstract syntax tree library (also imported by `rust.qll`) | ||
* - ``codeql.rust.controlflow.ControlFlowGraph`` | ||
- The control flow graph library | ||
* - ``codeql.rust.dataflow.DataFlow`` | ||
- The data flow library | ||
* - ``codeql.rust.dataflow.TaintTracking`` | ||
- The taint tracking library |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.