Skip to content

CPP: Add a test of ConditionalDeclExpr. #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2019
Merged

CPP: Add a test of ConditionalDeclExpr. #1945

merged 1 commit into from
Sep 18, 2019

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Sep 18, 2019

No description provided.

@geoffw0 geoffw0 added the C++ label Sep 18, 2019
@geoffw0 geoffw0 requested a review from a team as a code owner September 18, 2019 08:03
@geoffw0 geoffw0 mentioned this pull request Sep 18, 2019
Closed
jbj
jbj approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@jbj jbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we have reasonably good coverage of ConditionDeclExpr already, including edge cases like initialising a type with a destructor and then using break or continue in the loop. Those are in library-tests/syntax-zoo.

@jbj jbj merged commit e7d8fa4 into github:master Sep 18, 2019
@geoffw0
Copy link
Contributor Author

geoffw0 commented Sep 18, 2019

Yes, I created the test for the benefit of a discussion in #1864, and figured I might as well get the test merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbj jbj jbj approved these changes

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffw0 @jbj