C#: Handle unbound types in conversion library #2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A constructed type, `C<T>`, where `T` is the type parameter of `C`, is represented in the database as the corresponding unbound generict type `C<>`. Consequently, the type conversion library, which only considers `ConstructedType`s, does not handle all implicit conversions. For example, in ``` interface I<in T1, T2> where T1 : C ``` there should be an implicit conversion from `I<C, T2>` to `I<T1, T2>` (=`I<>`).
calumgrant
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A constructed type,
C<T>, whereTis the type parameter ofC, is represented in the database as the corresponding unbound generict typeC<>. Consequently, the type conversion library, which only considersConstructedTypes, does not handle all implicit conversions. For example, inthere should be an implicit conversion from
I<C, T2>toI<T1, T2>(=I<>).dist-compare report here (internal link).