Skip to content

CPP: Add a quick test of ErroneousType. #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2019
Merged

CPP: Add a quick test of ErroneousType. #2315

merged 1 commit into from
Nov 13, 2019

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Nov 13, 2019

See discussion in #2309 (comment).

@geoffw0 geoffw0 added the C++ label Nov 13, 2019
@geoffw0 geoffw0 requested a review from a team as a code owner November 13, 2019 18:57
@geoffw0 geoffw0 mentioned this pull request Nov 13, 2019
Merged
dbartol
dbartol approved these changes Nov 13, 2019
View reviewed changes
Copy link

@dbartol dbartol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbartol dbartol merged commit 55010d0 into github:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dbartol dbartol dbartol approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffw0 @dbartol