-
Notifications
You must be signed in to change notification settings - Fork 1.7k
JS: Monorepo support: bugfixes and separate from dependency installation #3731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS: Monorepo support: bugfixes and separate from dependency installation #3731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good to me.
But the tests are failing, and not in a good way.
I'm not sure what is happening, but it might be that you are missing some files during the extraction?
Oh, I completely messed up the alias check. Surprisingly it still seems to work for kibana after fixing that, but I'll run some evaluations again. |
Another evaluation looks exactly the same after fixing that bug. ¯\_(ツ)_/¯ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, strangely, the only project failing the distribution build was kibana. 🤔 |
f9191a1
to
e28284b
Compare
New evaluations:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny non-blocking comment about documentation.
Otherwise LGTM 👍
/** | ||
* Returns the virtual source root or <code>null</code> if no virtual source root exists. | ||
* | ||
* <p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* <p> | |
* |
There is a whole bunch of the <p>
throughout the documentation, and none of them have an corresponding </p>
.
You don't have to fix this one, because there is a bunch more throughout our .java
files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The </p>
is not needed and our auto-formatter removes them.
Without the <p>
javadoc won't create a separate paragraph for the following text, not even a newline.
* tsconfig.json file. | ||
*/ | ||
public static final Comparator<Path> PATH_ORDERING = new Comparator<Path>() { | ||
public int compare(Path f1, Path f2) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this change introduces an alert on the internal LGTM instance:
This method overrides Comparator.compare; it is advisable to add an Override annotation.
* Like {@link #PATH_ORDERING} but for {@link File} objects. | ||
*/ | ||
public static final Comparator<File> FILE_ORDERING = new Comparator<File>() { | ||
public int compare(File f1, File f2) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
This PR largely does four things:
LGTM_SRC
as source root instead of CWD. The latter only worked incodeql
.Evaluations
Dist upgrade
Commit-by-commit review recommended.