Skip to content

JS: add crypto.pseudoRandomBytes as source in InsecureRandomness.ql #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

asger-semmle
Copy link
Contributor

Evaluation underway

@asger-semmle asger-semmle requested a review from a team as a code owner December 6, 2018 13:48
xiemaisi
xiemaisi previously approved these changes Dec 6, 2018
Copy link

@xiemaisi xiemaisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; evaluation is nice, but not strictly necessary for merging, I would say.

@asger-semmle
Copy link
Contributor Author

Rebased to resolve change note conflict.

LGTM; evaluation is nice, but not strictly necessary for merging, I would say.

The evaluation broke anyway. Let's just land it like this.

xiemaisi
xiemaisi previously approved these changes Dec 12, 2018
@xiemaisi xiemaisi added the JS label Dec 13, 2018
@xiemaisi xiemaisi merged commit 54bb9d1 into github:master Dec 13, 2018
cklin pushed a commit that referenced this pull request May 23, 2022
…ns-for-builtin-functions

Refactor isVariadic helper functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants