C#: Fix a bug in ThrowingCallable
#637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A method such as
```
void M()
{
throw new Exception();
}
```
was incorrectly not categorized as a `ThrowingCallable`, that is, a callable
that always throws an exception upon invocation.
calumgrant
reviewed
Dec 11, 2018
| c.getExceptionClass() = te.getThrownExceptionType() and | ||
| // For stub implementations, there may exist proper implementations that are not seen | ||
| // during compilation, so we conservatively rule those out | ||
| not isStub(te) |
There was a problem hiding this comment.
I realise this is the previous logic, but doesn't it make sense to have isStub at a higher level, for example the callable or the class?
There was a problem hiding this comment.
Perhaps at the callable level, but usually that would be one-to-one with the throw statement. I don't think the whole class needs to be a stub for one of the callables to be a stub.
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
…zers Fix sanitization by strings.Replace[All] in go/unsafe-quoting and go/log-injection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A method such as
was incorrectly not categorized as a
ThrowingCallable, that is, a callable that always throws an exception upon invocation.